Fix segfault in eq tab (only occurred in release mode)

Author: ThePBone

dialog/liquidequalizerwidget.cpp

@@ -154,9 +154,10 @@ void LiquidEqualizerWidget::paintEvent(QPaintEvent* event){
     QPainterPath frequencyResponse;
     double gain = pow(10,mLevels[0] / 20.0);
 
-    for (int i = 0; i < BANDS_NUM; i++) {
+    for (int i = 0; i < BANDS_NUM - 1; i++) {
         double frequency = 15.625 * pow(2.0,i + 0.65);
-        biquads[i].refreshFilter(i,biquad::HIGH_SHELF, mLevels[i + 1] - mLevels[i],frequency * 2,SAMPLING_RATE,1,true);
+        double diff = mLevels[i + 1] - mLevels[i];
+        biquads[i].refreshFilter(i,biquad::HIGH_SHELF, diff,frequency * 2,SAMPLING_RATE,1,true);
     }
 
     for (int i = 0; i < 128; i++) {
@@ -246,7 +247,8 @@ void LiquidEqualizerWidget::setBand(int i, float value, bool animate, bool manua
     mSelectedBand = i;
     mManual = manual;
     if(animate){
-        anim[i]->stop();
+        if(anim[i] != nullptr)
+            anim[i]->stop();
         anim[i] = new QVariantAnimation(this);
         anim[i]->setDuration(500);
         anim[i]->setEasingCurve(QEasingCurve(QEasingCurve::Type::InOutCirc));

mainwindow.cpp

@@ -1008,7 +1008,7 @@ void MainWindow::UpdateAllUnitLabels(){
 }
 
 //---Helper
-void MainWindow::SetEQ(const std::initializer_list<float> data){
+void MainWindow::SetEQ(const QVector<float> data){
     lockapply=true;
     ui->eq_widget->setBands(QVector<float>(data));
     lockapply=false;

mainwindow.h

@@ -57,7 +57,7 @@ class MainWindow : public QMainWindow
     void SavePresetFile(const QString&);
     AppConfigWrapper* getACWrapper();
     explicit MainWindow(QString exepath,bool traySwitch,bool allowMultipleInst,QWidget *parent = nullptr);
-    void SetEQ(const std::initializer_list<float> data);
+    void SetEQ(const QVector<float> data);
     void SetIRS(const QString& irs,bool apply);
     QString GetExecutablePath();
     void setVisible(bool visible) override;

misc/overlaymsgproxy.cpp

@@ -16,7 +16,7 @@ OverlayMsgProxy::OverlayMsgProxy(QWidget* _obj)
 }
 
 void OverlayMsgProxy::openError(QString title, QString desc, QString close){
-    openBase(title,desc,":/icons/error.svg",close,"#d72828");
+    //TODO: uncomment - openBase(title,desc,":/icons/error.svg",close,"#d72828");
 }
 void OverlayMsgProxy::openNormal(QString title, QString desc, QString color){
     openBase(title,desc,"",tr("Close"),color);

misc/presetprovider.h

@@ -19,7 +19,7 @@
 #include <QVector>
 #include "initializableqmap.h"
 
-#define FLOAT_LIST std::initializer_list<float>
+#define FLOAT_LIST QVector<float>
 #define INT_LIST std::initializer_list<int>
 
 #define EQ_UNIT QString,FLOAT_LIST