Completed adding the Talkbox

Author: aure

Sources/CSoundpipeAudioKit/Effects/Talkbox.mm

@@ -10,7 +10,8 @@
 
 class TalkboxDSP : public SoundpipeDSPBase {
 private:
-    sp_talkbox *talkbox;
+    sp_talkbox *talkboxL;
+    sp_talkbox *talkboxR;
     ParameterRamper qualityRamp{1.0};
 
 public:
@@ -21,32 +22,43 @@
 
     void init(int channelCount, double sampleRate) override {
         SoundpipeDSPBase::init(channelCount, sampleRate);
-        sp_talkbox_create(&talkbox);
-        sp_talkbox_init(sp, talkbox);
+        sp_talkbox_create(&talkboxL);
+        sp_talkbox_init(sp, talkboxL);
+        sp_talkbox_create(&talkboxR);
+        sp_talkbox_init(sp, talkboxR);
     }
 
     void deinit() override {
         SoundpipeDSPBase::deinit();
-        sp_talkbox_destroy(&talkbox);
+        sp_talkbox_destroy(&talkboxL);
+        sp_talkbox_destroy(&talkboxR);
     }
 
     void reset() override {
         SoundpipeDSPBase::reset();
         if (!isInitialized) return;
-        sp_talkbox_init(sp, talkbox);
+        sp_talkbox_init(sp, talkboxL);
+        sp_talkbox_init(sp, talkboxR);
     }
 
     void process(FrameRange range) override {
         for (int i : range) {
-            float sourceIn = inputSample(0, i);      // source input (first input stream)
-            float excitationIn = input2Sample(0, i); // excitation input (second input stream)
-            float outSample;
+            float sourceInL = inputSample(0, i);      // modulator input left
+            float sourceInR = inputSample(1, i);      // modulator input right
+            float excitationInL = input2Sample(0, i); // carrier input left
+            float excitationInR = input2Sample(1, i); // carrier input right
+            float outSampleL;
+            float outSampleR;
 
-            talkbox->quality = qualityRamp.getAndStep();
- 
-            sp_talkbox_compute(sp, talkbox, &sourceIn, &excitationIn, &outSample);
+            float quality = qualityRamp.getAndStep();
+            talkboxL->quality = quality;
+            talkboxR->quality = quality;
 
-            outputSample(0, i) = outSample;
+            sp_talkbox_compute(sp, talkboxL, &sourceInL, &excitationInL, &outSampleL);
+            sp_talkbox_compute(sp, talkboxR, &sourceInR, &excitationInR, &outSampleR);
+
+            outputSample(0, i) = outSampleL;
+            outputSample(1, i) = outSampleR;
         }
     }
 };

Tests/SoundpipeAudioKitTests/Effects Tests/TalkboxTests.swift

@@ -0,0 +1,33 @@
+// Copyright AudioKit. All Rights Reserved. Revision History at http://github.com/AudioKit/AudioKit/
+
+import AudioKit
+import SoundpipeAudioKit
+import XCTest
+import AVFoundation
+
+class TalkboxTests: XCTestCase {
+    func testTalkbox() {
+        let engine = AudioEngine()
+        
+        let url = Bundle.module.url(forResource: "12345", withExtension: "wav", subdirectory: "TestResources")!
+        let source = AudioPlayer(url: url)!
+        
+        // Excitation/carrier (harmonically rich signal)
+        let excitation = DynamicOscillator(waveform: Table(.sawtooth), frequency: 220, amplitude: 1.0)
+        
+        // Create talkbox with both signals
+        let talkbox = Talkbox(source, excitation: excitation)
+        
+        engine.output = talkbox
+        
+        let audio = engine.startTest(totalDuration: 5.0)
+        
+        // Start both signals
+        source.play()
+        excitation.play()
+
+        audio.append(engine.render(duration: 5.0))
+        
+        testMD5(audio)
+    }
+}

Tests/SoundpipeAudioKitTests/ValidatedMD5s.swift

@@ -50,4 +50,5 @@ let validatedMD5s: [String: String] = [
     "-[PhaseLockedVocoderTests testDefault]": "eb9fe2d8ee2e3b3d6527a4e139c2686e",
     "-[PitchTapTests testBasic]": "5b6ae6252df77df298996a7367a00a9e",
     "-[PluckedStringTests testDefault]": "3f13907e6e916b7a4bf6046a4cbf0764",
+    "-[TalkboxTests testTalkbox]": "3ce43649658faa30bdb46124e48d00fb",
 ]