change 'else' to 'else if'

emurray2 · emurray2 · commit 3883f3c4f46c · 2021-08-07T08:23:15.000-05:00
This is probably a better idea so the internalTrigger doesn't reset when it receives other events besides MIDI_NOTE_OFF
diff --git a/Sources/CSoundpipeAudioKit/Effects/AmplitudeEnvelopeDSP.mm b/Sources/CSoundpipeAudioKit/Effects/AmplitudeEnvelopeDSP.mm
@@ -50,7 +50,7 @@ void handleMIDIEvent(AUMIDIEvent const& midiEvent) override {
 
         if (status == MIDI_NOTE_ON) {
             internalTrigger = midiEvent.data[2] / 127.0;
-        } else {
+        } else if (status == MIDI_NOTE_OFF) {
             internalTrigger = 0;
         }
     }
@@ -65,6 +65,7 @@ void process(FrameRange range) override {
             adsr->rel = releaseDurationRamp.getAndStep();
 
             sp_adsr_compute(sp, adsr, &internalTrigger, &amp);
+            printf("%.2f\n", amp);
             outputSample(0, i) = inputSample(0, i) * amp;
             outputSample(1, i) = inputSample(1, i) * amp;
         }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ void handleMIDIEvent(AUMIDIEvent const& midiEvent) override {`
`50`	`50`
`51`	`51`	`if (status == MIDI_NOTE_ON) {`
`52`	`52`	`internalTrigger = midiEvent.data[2] / 127.0;`
`53`		`- } else {`
	`53`	`+ } else if (status == MIDI_NOTE_OFF) {`
`54`	`54`	`internalTrigger = 0;`
`55`	`55`	`}`
`56`	`56`	`}`
`@@ -65,6 +65,7 @@ void process(FrameRange range) override {`
`65`	`65`	`adsr->rel = releaseDurationRamp.getAndStep();`
`66`	`66`
`67`	`67`	`sp_adsr_compute(sp, adsr, &internalTrigger, &amp);`
	`68`	`+ printf("%.2f\n", amp);`
`68`	`69`	`outputSample(0, i) = inputSample(0, i) * amp;`
`69`	`70`	`outputSample(1, i) = inputSample(1, i) * amp;`
`70`	`71`	`}`