Add balance to Chowing and Costello Reverb (init)

Author: aure

Sources/CSoundpipeAudioKit/Effects/ChowningReverbDSP.mm

@@ -4,13 +4,19 @@
 #include "ParameterRamper.h"
 #include "Soundpipe.h"
 
+enum ChowningReverbParameter : AUParameterAddress {
+    ChowningReverbParameterBalance,
+};
+
 class ChowningReverbDSP : public SoundpipeDSPBase {
 private:
     sp_jcrev *jcrev0;
     sp_jcrev *jcrev1;
+    ParameterRamper balanceRamp{1.0};
 
 public:
     ChowningReverbDSP() {
+        parameters[ChowningReverbParameterBalance] = &balanceRamp;
     }
 
     void init(int channelCount, double sampleRate) override {
@@ -40,13 +46,19 @@ void process(FrameRange range) override {
             float leftIn = inputSample(0, i);
             float rightIn = inputSample(1, i);
 
-            float &leftOut = outputSample(0, i);
-            float &rightOut = outputSample(1, i);
+            float leftWet;
+            float rightWet;
+
+            sp_jcrev_compute(sp, jcrev0, &leftIn, &leftWet);
+            sp_jcrev_compute(sp, jcrev1, &rightIn, &rightWet);
+
+            float bal = balanceRamp.getAndStep();
 
-            sp_jcrev_compute(sp, jcrev0, &leftIn, &leftOut);
-            sp_jcrev_compute(sp, jcrev1, &rightIn, &rightOut);
+            outputSample(0, i) = bal * leftWet + (1-bal) * leftIn;
+            outputSample(1, i) = bal * rightWet + (1-bal) * rightIn;
         }
     }
 };
 
 AK_REGISTER_DSP(ChowningReverbDSP, "jcrv")
+AK_REGISTER_PARAMETER(ChowningReverbParameterBalance)

Sources/SoundpipeAudioKit/Effects/ChowningReverb.swift

@@ -26,18 +26,36 @@ public class ChowningReverb: Node {
 
     // MARK: - Parameters
 
+    /// Dry/wet mix.
+    public static let balanceDef = NodeParameterDef(
+        identifier: "balance",
+        name: "Balance",
+        address: akGetParameterAddress("CostelloReverbParameterBalance"),
+        defaultValue: 1,
+        range: 0 ... 1,
+        unit: .percent
+    )
+
+    /// Dry/wet mix. Should be a value between 0-1.
+    @Parameter(balanceDef) public var balance: AUValue
+
+
     // MARK: - Initialization
 
     /// Initialize this reverb node
     ///
     /// - Parameters:
     ///   - input: Input node to process
+    ///   - balance: dry wet mix
     ///
     public init(
-        _ input: Node
+        _ input: Node,
+        balance: AUValue = balanceDef.defaultValue
     ) {
         self.input = input
 
         setupParameters()
+        
+        self.balance = balance
     }
 }

Sources/SoundpipeAudioKit/Effects/CostelloReverb.swift

@@ -65,18 +65,21 @@ public class CostelloReverb: Node {
     ///
     /// - Parameters:
     ///   - input: Input node to process
+    ///   - balance: dry wet mix
     ///   - feedback: Feedback level in the range 0 to 1. 0.6 gives a good small 'live' room sound, 0.8 a small hall, and 0.9 a large hall. A setting of exactly 1 means infinite length, while higher values will make the opcode unstable.
     ///   - cutoffFrequency: Low-pass cutoff frequency.
     ///
     public init(
         _ input: Node,
+        balance: AUValue = balanceDef.defaultValue,
         feedback: AUValue = feedbackDef.defaultValue,
         cutoffFrequency: AUValue = cutoffFrequencyDef.defaultValue
     ) {
         self.input = input
 
         setupParameters()
 
+        self.balance = balance
         self.feedback = feedback
         self.cutoffFrequency = cutoffFrequency
     }