Fixed Vocoder

Author: aure

Sources/CSoundpipeAudioKit/Effects/VocoderDSP.mm

@@ -17,13 +17,6 @@
     ParameterRamper attackRamp{0.1};
     ParameterRamper releaseRamp{0.1};
     ParameterRamper bwRatioRamp{0.5};
-    
-    float attackTimeL = 0.1;
-    float releaseTimeL = 0.1;
-    float bwRatioL = 0.5;
-    float attackTimeR = 0.1;
-    float releaseTimeR = 0.1;
-    float bwRatioR = 0.5;
 
 public:
     VocoderDSP() {
@@ -35,9 +28,13 @@
 
     void init(int channelCount, double sampleRate) override {
         SoundpipeDSPBase::init(channelCount, sampleRate);
+        
+        // Create and initialize vocoders first
         sp_vocoder_create(&vocoderL);
-        sp_vocoder_init(sp, vocoderL);
         sp_vocoder_create(&vocoderR);
+
+        // Initialize vocoders after setting parameters
+        sp_vocoder_init(sp, vocoderL);
         sp_vocoder_init(sp, vocoderR);
     }
 
@@ -50,6 +47,7 @@ void deinit() override {
     void reset() override {
         SoundpipeDSPBase::reset();
         if (!isInitialized) return;
+        
         sp_vocoder_init(sp, vocoderL);
         sp_vocoder_init(sp, vocoderR);
     }
@@ -62,22 +60,11 @@ void process(FrameRange range) override {
             float excitationInR = input2Sample(1, i); // modulator input right
             float outSampleL;
             float outSampleR;
-
-            attackTimeL = attackRamp.getAndStep();
-            releaseTimeL = releaseRamp.getAndStep();
-            bwRatioL = bwRatioRamp.getAndStep();
 
-            attackTimeR = attackTimeL;
-            releaseTimeR = releaseTimeL;
-            bwRatioR = bwRatioL;
-
-            vocoderL->atk = &attackTimeL;
-            vocoderL->rel = &releaseTimeL;
-            vocoderL->bwratio = &bwRatioL;
-            vocoderR->atk = &attackTimeR;
-            vocoderR->rel = &releaseTimeR;
-            vocoderR->bwratio = &bwRatioR;
-
+            *vocoderL->atk = *vocoderR->atk = attackRamp.getAndStep();
+            *vocoderL->rel = *vocoderR->rel = releaseRamp.getAndStep();
+            *vocoderL->bwratio = *vocoderR->bwratio = bwRatioRamp.getAndStep();
+            
             sp_vocoder_compute(sp, vocoderL, &sourceInL, &excitationInL, &outSampleL);
             sp_vocoder_compute(sp, vocoderR, &sourceInR, &excitationInR, &outSampleR);
 

Tests/SoundpipeAudioKitTests/Effects Tests/VocoderTests.swift

@@ -16,9 +16,9 @@ class VocoderTests: XCTestCase {
         excitation.$frequency.ramp(to: 440, duration: 5.0)
 
         // Create vocoder with both signals
-        let vocoder = Vocoder(source, excitation: excitation, attackTime: 0.123, releaseTime: 0.24, bandwidthRatio: 0.324)
-        vocoder.$attackTime.ramp(from: 0.01, to: 0.5, duration: 5.0)
-        vocoder.$releaseTime.ramp(from: 0.01, to: 0.5, duration: 5.0)
+        let vocoder = Vocoder(source, excitation: excitation)
+        vocoder.$attackTime.ramp(from: 0.1, to: 0.5, duration: 5.0)
+        vocoder.$releaseTime.ramp(from: 0.1, to: 0.5, duration: 5.0)
         vocoder.$bandwidthRatio.ramp(from: 0.1, to: 2.0, duration: 5.0)
 
         engine.output = vocoder
@@ -32,7 +32,5 @@ class VocoderTests: XCTestCase {
         audio.append(engine.render(duration: 5.0))
 
         testMD5(audio)
-//        audio.audition()
     }
 }
-

Tests/SoundpipeAudioKitTests/ValidatedMD5s.swift

@@ -51,5 +51,5 @@ let validatedMD5s: [String: String] = [
     "-[PitchTapTests testBasic]": "5b6ae6252df77df298996a7367a00a9e",
     "-[PluckedStringTests testDefault]": "3f13907e6e916b7a4bf6046a4cbf0764",
     "-[TalkboxTests testTalkbox]": "316ef6638793f5fb6ec43fae1919ccff",
-    "-[VocoderTests testVocoder]": "1e084a4d0399923b923ff6a07dc8a320",
+    "-[VocoderTests testVocoder]": "3836def448fed8ac901b179e943e6922",
 ]