boot: serial: unable to detect cbor encode overrun (wrong buf-size)

Mads Bligaard Nielsen · Mads Bligaard Nielsen · commit e6456ee975e9 · 2023-01-16T09:25:33.000+01:00
* reset_cbor_state() used buffer-end-address as buffer length (payload_len)
diff --git a/boot/boot_serial/src/boot_serial.c b/boot/boot_serial/src/boot_serial.c
@@ -125,7 +125,7 @@ static zcbor_state_t cbor_state[2];
 void reset_cbor_state(void)
 {
     zcbor_new_encode_state(cbor_state, 2, (uint8_t *)bs_obuf,
-        (size_t)bs_obuf + sizeof(bs_obuf), 0);
+        sizeof(bs_obuf), 0);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ static zcbor_state_t cbor_state[2];`
`125`	`125`	`void reset_cbor_state(void)`
`126`	`126`	`{`
`127`	`127`	`zcbor_new_encode_state(cbor_state, 2, (uint8_t *)bs_obuf,`
`128`		`- (size_t)bs_obuf + sizeof(bs_obuf), 0);`
	`128`	`+ sizeof(bs_obuf), 0);`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`/**`