Skip to content

Commit 0ae4998

Browse files
committed
Coverage human tracking options fix
1 parent 1d18aac commit 0ae4998

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

js/UI/Popup.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ class Popup{
483483
else
484484
{
485485
getCamerasTypes().filter(c => c.recommended).forEach(c => {
486-
const overlapHeightDetection = trackingMode === 'human-tracking' ? SceneManager.DEFAULT_DETECTION_HEIGHT : SceneManager.HAND_TRACKING_OVERLAP_HEIGHT;
486+
const overlapHeightDetection = trackingMode === 'human-tracking' ? heightDetected : SceneManager.HAND_TRACKING_OVERLAP_HEIGHT;
487487
if(checkCameraCoherence(givenHeight, overlapHeightDetection, trackingMode === 'hand-tracking' ? c.handFar : c.rangeFar, c.rangeNear))
488488
{ sensorsCompatible.push(c) }
489489
})
@@ -657,7 +657,7 @@ class Popup{
657657
case 'hand-tracking':
658658
{
659659
const sensor = getCamerasTypes().find(sensorType => sensorType.textId === sensorTextId);
660-
const overlapHeightDetection = trackingMode === 'human-tracking' ? SceneManager.DEFAULT_DETECTION_HEIGHT : SceneManager.HAND_TRACKING_OVERLAP_HEIGHT;
660+
const overlapHeightDetection = trackingMode === 'human-tracking' ? heightDetected : SceneManager.HAND_TRACKING_OVERLAP_HEIGHT;
661661
const config = calculateCameraConfig(trackingMode, sensor, givenWidth, givenLength, givenHeight, overlapHeightDetection);
662662
if(!config){
663663
console.error('no config found with this setup');
@@ -712,7 +712,7 @@ class Popup{
712712
function selectFirstSensorAvailable()
713713
{
714714
const sensorsDiv = document.getElementById('multi-select-sensors');
715-
if(!sensorsDiv) return;
715+
if(!sensorsDiv.children[0]) return;
716716
sensorsDiv.value = sensorsDiv.children[0].value;
717717
createSceneFromSelectedSensor();
718718
//Old way

0 commit comments

Comments
 (0)