Skip to content

Commit 179fadc

Browse files
author
Léna Voinchet
committed
Fix a bug on lidar display
1 parent bb4ec6d commit 179fadc

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

js/UI/Popup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ class Popup{
534534
if(trackingMode === "wall-tracking")
535535
{
536536
getLidarsTypes().filter(l => l.recommended).forEach(l => {
537-
if(checkLidarCoherence(givenWidth, givenHeight, l.rangeFar, trackingMode))
537+
if(checkLidarCoherence(givenWidth, givenHeight, l.rangeFar))
538538
{ sensorsCompatible.push(l) }
539539
})
540540
}

js/ViewportManager.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,10 @@ class ViewportManager{
6767

6868
if (ownerInstance) {
6969
// Update Node/LiDAR/Dummy 's properties
70+
if (ownerInstance instanceof Node || ownerInstance instanceof Dummy) {
71+
ownerInstance.yPos = changedObject3D.position.z;
72+
}
7073
ownerInstance.xPos = changedObject3D.position.x;
71-
ownerInstance.yPos = changedObject3D.position.z;
7274
ownerInstance.zPos = changedObject3D.position.y;
7375

7476
if (transfControl.mode === 'rotate') {
@@ -77,7 +79,7 @@ class ViewportManager{
7779
ownerInstance.yRot = -meshRotation.y;
7880
ownerInstance.zRot = meshRotation.z;
7981
}
80-
82+
8183
// Update 3D Component
8284
ownerInstance.updateTransformation();
8385

0 commit comments

Comments
 (0)