Skip to content

Commit 51a9c8c

Browse files
author
Léna Voinchet
committed
Fix id of sensors
1 parent 50cf2c5 commit 51a9c8c

File tree

1 file changed

+20
-6
lines changed

1 file changed

+20
-6
lines changed

js/scene/objects/SceneObjects.js

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ class SceneObjects{
3131
this.nodeMeshes = [];
3232
this.lidarsMeshes = [];
3333
this.dummiesMeshes = [];
34-
this.numberOfNodesCreated = 0;
35-
this.numberOfLidarsCreated = 0;
3634

3735
const givenAreaPolygonRegions = [[]];
3836

@@ -158,8 +156,16 @@ class SceneObjects{
158156
console.log("Add Node button will work in an instant");
159157
return;
160158
}
161-
const newCamera = new Node(this.numberOfNodesCreated, mode, typeID, x, y, z, p, a, r);
162-
this.numberOfNodesCreated++;
159+
160+
let idOfNode = 0;
161+
162+
// Method .some() returns true if AT LEAST one element of the array passes the test
163+
while (nodes.some(node => node.id === idOfNode)) {
164+
idOfNode++;
165+
}
166+
167+
const newCamera = new Node(idOfNode, mode, typeID, x, y, z, p, a, r);
168+
163169
if(!isBuilder) newCamera.uiElement = new NodeUI(newCamera, sceneManager);
164170

165171
//Offset
@@ -276,8 +282,16 @@ class SceneObjects{
276282
console.log("Add Lidar button will work in an instant");
277283
return;
278284
}
279-
const newLidar = new Lidar(this.numberOfLidarsCreated, sizeDetected, typeID, x, z, r);
280-
this.numberOfLidarsCreated++;
285+
286+
let idOfLidar = 0;
287+
288+
// Method .some() returns true if AT LEAST one element of the array passes the test
289+
while (lidars.some(lidar => lidar.id === idOfLidar)) {
290+
idOfLidar++;
291+
}
292+
293+
const newLidar = new Lidar(idOfLidar, sizeDetected, typeID, x, z, r);
294+
281295
if(!isBuilder) newLidar.uiElement = new LidarUI(newLidar, sceneManager);
282296

283297
// Offset

0 commit comments

Comments
 (0)