Skip to content

Commit 9b0455b

Browse files
committed
Coverage table bug fix + small fixes
1 parent 3bf7c6b commit 9b0455b

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

css/main.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -921,15 +921,15 @@ textarea:focus {
921921
}
922922

923923
#sensor-height-infos-text{
924-
background-color: var(--color-grey-selectable);
924+
background-color: var(--color-grey);
925925
max-width: 150px;
926926
padding: 10px;
927927
border-radius: 5px;
928928
position: absolute;
929929
}
930930

931931
#sensor-height-infos-text p{
932-
color: var(--color-grey-background-selected-item);
932+
color: var(--color-dark-purple);
933933
padding: 0;
934934
margin:0;
935935
}

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ <h3>Front wall scene size</h3>
622622
<!-- SENSORS PANEL -->
623623
<div id="sensors-infos" class="column sections-container">
624624
<!-- SCENE COVERED FEEDBACK -->
625-
<div class="row">
625+
<div class="row" id="coverage-section">
626626
<p class="scene-fully-covered-text">Scene fully covered: </p>
627627
<span id="scene-fully-covered-icon" class="iconify-inline" data-icon="ion:checkmark-circle-sharp"></span>
628628
</div>

js/UI/Popup.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ class Popup{
109109
document.getElementById("setup-target-overlap-table").classList.remove("hidden");
110110
document.getElementById("setup-target-overlap").classList.add("hidden");
111111
document.getElementById("setup-target-overlap-wall").classList.add("hidden");
112+
sceneManager.heightDetectedObservable.set(0.25);
112113
break;
113114
case 'human-tracking':
114115
document.getElementById("setup-target-overlap").classList.remove("hidden");
@@ -123,7 +124,7 @@ class Popup{
123124
this.setHeightDetected = function(value){
124125
//console.log("Setting detected height to ", value);
125126
heightDetected = value;
126-
document.getElementById("overlap-height-selection-popup").value = heightDetected;
127+
if(trackingMode == "human-tracking") document.getElementById("overlap-height-selection-popup").value = heightDetected;
127128
}
128129

129130
/** SETUP SECTION */
@@ -378,7 +379,8 @@ class Popup{
378379
document.getElementById('dimensions-width-input').value = Math.floor(sceneSize[0] * sceneManager.currentUnit.value * 100) / 100;
379380
document.getElementById('dimensions-length-input').value = Math.floor(sceneSize[1] * sceneManager.currentUnit.value * 100) / 100;
380381
const nodes = JSON.parse(sceneInfos).objects.nodes;
381-
if(nodes.length > 0) document.getElementById('dimensions-distance-input').value = Math.floor((nodes[0].p_z - (trackingMode === 'hand-tracking' ? SceneManager.TABLE_ELEVATION : 0)) * sceneManager.currentUnit.value * 100) / 100;
382+
//The value 2.5 for hand-tracking is just to address the fact that the sensor is by default the human-tracking one
383+
if(nodes.length > 0) document.getElementById('dimensions-distance-input').value = Math.floor((nodes[0].p_z - (trackingMode === 'hand-tracking' ? 2.5 : 0)) * sceneManager.currentUnit.value * 100) / 100;
382384
else document.getElementById('dimensions-distance-input').value = '';
383385
break;
384386
default:

js/UI/UIManager.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,14 +186,17 @@ class UIManager{
186186

187187
switch (trackingMode) {
188188
case 'hand-tracking':
189+
document.getElementById("coverage-section").classList.remove("hidden");
189190
document.getElementById("height-detection-text").classList.add("hidden");
190191
document.getElementById('scene-size-text-div').innerHTML= '<h3 id="scene-size-text">Scene size: <span data-unit=1>' + sceneManager.sceneWidth +'</span>x<span data-unit=1>'+ sceneManager.sceneWidth +'</span><span data-unittext="1">m</span> with a sensor height of <span data-unit="1">' + sceneManager.sceneSensorHeight + '</span><span data-unittext="1">m</span></h3>';
191192
break;
192193
case 'wall-tracking':
194+
document.getElementById("coverage-section").classList.add("hidden");
193195
document.getElementById("height-detection-text").classList.add("hidden");
194196
document.getElementById('scene-size-text-div').innerHTML= '<h3 id="scene-size-text">Scene size: <span data-unit=1>' + sceneManager.sceneWidth +'</span>x<span data-unit=1>'+ sceneManager.sceneLength +'</span><span data-unittext="1">m</span></h3>';
195197
break;
196198
case 'human-tracking':
199+
document.getElementById("coverage-section").classList.remove("hidden");
197200
document.getElementById("height-detection-text").classList.remove("hidden");
198201
document.getElementById('scene-size-text-div').innerHTML= '<h3 id="scene-size-text">Scene size: <span data-unit=1>' + sceneManager.sceneWidth +'</span>x<span data-unit=1>'+ sceneManager.sceneWidth +'</span><span data-unittext="1">m</span> with a sensor height of <span data-unit="1">' + sceneManager.sceneSensorHeight + '</span><span data-unittext="1">m</span></h3>';
199202
break;

0 commit comments

Comments
 (0)