Skip to content

Commit d9e9b3a

Browse files
committed
fixes based on PR feedback. added newline, removed typo, reverted change to add back in return true;
1 parent 200e107 commit d9e9b3a

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

source/contracts/reporting/FeeWindow.sol

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,13 @@ contract FeeWindow is DelegationTarget, VariableSupplyToken, Extractable, Initia
7979
}
8080

8181
function redeemForReportingParticipant() public returns (bool) {
82-
return redeemInternal(msg.sender, true);
82+
redeemInternal(msg.sender, true);
83+
return true;
8384
}
8485

8586
function redeem(address _sender) public returns (bool) {
86-
return redeemInternal(_sender, false);
87+
redeemInternal(_sender, false);
88+
return true;
8789
}
8890

8991
function redeemInternal(address _sender, bool _isReportingParticipant) private returns (bool) {

tests/solidity_test_helpers/MockReputationToken.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'reporting/IUniverse.sol';
99
import 'reporting/IMarket.sol';
1010
import 'reporting/Reporting.sol';
1111
import 'libraries/math/SafeMathUint256.sol';
12-
import 'TEST/MockVariableSupplyToken.sol';import 'TEST/MockVariableSupplyToken.sol';
12+
import 'TEST/MockVariableSupplyToken.sol';
1313

1414

1515
contract MockReputationToken is DelegationTarget, ITyped, Initializable, MockVariableSupplyToken, IReputationToken {

tests/unit/test_fee_window.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,4 +260,4 @@ def mockInitialReporter(localFixture):
260260

261261
@fixture
262262
def Time(localFixture):
263-
return localFixture.contracts["Time"]
263+
return localFixture.contracts["Time"]

0 commit comments

Comments
 (0)