#477 Build with all Java 8+ LTS versions (#487)

* Add matrix build for Java LTS versions above Java 8
* Specify permissions to GHA files

Author: ljacqu

.github/workflows/maven_jdk11.yml

@@ -2,6 +2,8 @@
 
 name: Java 8 build
 on: [push, pull_request]
+permissions:
+  contents: read
 
 jobs:
   build:

.github/workflows/maven_jdk8.yml

@@ -0,0 +1,25 @@
+# Secondary build that builds the project with JDK 11+. Note that the target in the pom.xml is still Java 8.
+
+name: Maven build
+on: [push, pull_request]
+permissions:
+  contents: read
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        # Java 8 has its own file so we can do other stuff like Coveralls
+        java: ['11', '17', '21']
+    name: Java ${{ matrix.java }} build
+
+    steps:
+      - uses: actions/checkout@v5
+      - name: Set up Java
+        uses: actions/setup-java@v5
+        with:
+          java-version: ${{ matrix.java }}
+          distribution: 'adopt'
+      - name: Build with Maven
+        run: mvn -B --file pom.xml package

.github/workflows/maven_jdk_lts.yml

@@ -3,6 +3,7 @@
 import ch.jalu.configme.properties.convertresult.ConvertErrorRecorder;
 import ch.jalu.typeresolver.TypeInfo;
 import ch.jalu.typeresolver.numbers.StandardNumberType;
+import org.hamcrest.Matchers;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -236,7 +237,9 @@ void shouldConvertToBigDecimalsWithoutLossOfPrecision() {
         // when / then
         assertThat(NumberType.BIG_DECIMAL.convert(longImpreciseAsDouble, bigDecimalType, errorRecorder), equalTo(new BigDecimal("5076541234567890123")));
         assertThat(NumberType.BIG_DECIMAL.convert(2e50, bigDecimalType, errorRecorder), equalTo(new BigDecimal("2.0E+50")));
-        assertThat(NumberType.BIG_DECIMAL.convert(-1e18f, bigDecimalType, errorRecorder), equalTo(new BigDecimal("-9.9999998430674944E+17")));
+        assertThat(NumberType.BIG_DECIMAL.convert(-1e18f, bigDecimalType, errorRecorder),
+            Matchers.<Object>either(equalTo(new BigDecimal("-9.9999998430674944E+17")))
+                .or(equalTo(new BigDecimal("-9.999999843067494E+17")))); // #347: JDK21 has different Double#toString impl.
         assertThat(NumberType.BIG_DECIMAL.convert("88223372036854775807.999", bigDecimalType, errorRecorder), equalTo(new BigDecimal("88223372036854775807.999")));
         assertThat(NumberType.BIG_DECIMAL.convert(largeBigDecimal, bigDecimalType, errorRecorder), equalTo(largeBigDecimal));
         verifyNoInteractions(errorRecorder);

src/test/java/ch/jalu/configme/properties/types/NumberTypeTest.java

@@ -26,7 +26,7 @@
 import static org.mockito.ArgumentMatchers.anySet;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.BDDMockito.given;
-import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.lenient;
 import static org.mockito.Mockito.mock;
 
 /**
@@ -88,7 +88,8 @@ void shouldThrowIfFileCannotBeCreated() throws IOException {
         given(fileSystem.provider()).willReturn(provider);
         Path child = mock(Path.class);
         given(child.getFileSystem()).willReturn(fileSystem);
-        doThrow(NoSuchFileException.class).when(provider).checkAccess(child); // for Files#exists
+        // #347: JDK21 does not call checkAccess anymore
+        lenient().doThrow(NoSuchFileException.class).when(provider).checkAccess(child); // for Files#exists
         IOException ioException = new IOException("File creation not supported");
         given(provider.newByteChannel(eq(child), anySet(), any(FileAttribute[].class))).willThrow(ioException);