#482 Use "no-arg constructor" everywhere

Author: ljacqu

src/main/java/ch/jalu/configme/SettingsHolder.java

@@ -10,7 +10,7 @@
  * of {@link ch.jalu.configme.properties.Property} type in a class
  * which implements this interface.
  * <p>
- * Classes implementing this interface must have a no-args constructor (any visibility).
+ * Classes implementing this interface must have a no-arg constructor (any visibility).
  *
  * @see ch.jalu.configme.properties.PropertyInitializer
  * @see ch.jalu.configme.configurationdata.ConfigurationDataBuilder

src/main/java/ch/jalu/configme/configurationdata/ConfigurationDataBuilder.java

@@ -181,7 +181,7 @@ protected void collectSectionComments(@NotNull Class<? extends SettingsHolder> c
             ReflectionHelper.setAccessibleIfNeeded(constructor);
             return constructor.newInstance();
         } catch (NoSuchMethodException e) {
-            throw new ConfigMeException("Expected no-args constructor to be available for " + clazz, e);
+            throw new ConfigMeException("Expected no-arg constructor to be available for " + clazz, e);
         } catch (IllegalAccessException | InstantiationException | InvocationTargetException e) {
             throw new ConfigMeException("Could not create instance of " + clazz, e);
         }

src/main/java/ch/jalu/configme/utils/SettingsHolderClassValidator.java

@@ -141,7 +141,7 @@ public void validateSettingsHolderClassesFinal(@NotNull Iterable<Class<? extends
 
     /**
      * Throws an exception if any of the provided setting holder classes does not have a single private
-     * no-args constructor.
+     * no-arg constructor.
      *
      * @param settingHolders the classes to check
      */
@@ -156,7 +156,7 @@ public void validateClassesHaveHiddenNoArgConstructor(
         }
 
         if (!invalidClasses.isEmpty()) {
-            throw new IllegalStateException("The following classes do not have a single no-args private constructor:"
+            throw new IllegalStateException("The following classes do not have a single no-arg private constructor:"
                 + "\n- " + String.join("\n- ", invalidClasses));
         }
     }

src/test/java/ch/jalu/configme/configurationdata/ConfigurationDataBuilderTest.java

@@ -61,10 +61,10 @@ void shouldGetAllProperties() {
     void shouldHandleSettingsHolderConstructorIssues() {
         ConfigMeException ex;
 
-        // Missing no-args constructor
+        // Missing no-arg constructor
         ex = assertThrows(ConfigMeException.class,
-            () -> ConfigurationDataBuilder.createConfiguration(IllegalSettingsHolderConstructorClasses.MissingNoArgsConstructor.class));
-        assertThat(ex.getMessage(), startsWith("Expected no-args constructor to be available for class "));
+            () -> ConfigurationDataBuilder.createConfiguration(IllegalSettingsHolderConstructorClasses.MissingNoArgConstructor.class));
+        assertThat(ex.getMessage(), startsWith("Expected no-arg constructor to be available for class "));
 
         // Constructor throws exception
         ex = assertThrows(ConfigMeException.class,
@@ -79,7 +79,7 @@ void shouldHandleSettingsHolderConstructorIssues() {
         // Class is interface
         ex = assertThrows(ConfigMeException.class,
             () -> ConfigurationDataBuilder.createConfiguration(IllegalSettingsHolderConstructorClasses.InterfaceSettingsHolder.class));
-        assertThat(ex.getMessage(), startsWith("Expected no-args constructor to be available for interface "));
+        assertThat(ex.getMessage(), startsWith("Expected no-arg constructor to be available for interface "));
     }
 
     @Test

src/test/java/ch/jalu/configme/configurationdata/samples/IllegalSettingsHolderConstructorClasses.java

@@ -12,11 +12,11 @@ private IllegalSettingsHolderConstructorClasses() {
     }
 
     /**
-     * Class doesn't have a no-args constructor.
+     * Class doesn't have a no-arg constructor.
      */
-    public final static class MissingNoArgsConstructor implements SettingsHolder {
+    public final static class MissingNoArgConstructor implements SettingsHolder {
 
-        MissingNoArgsConstructor(String str) {
+        MissingNoArgConstructor(String str) {
         }
     }
 

src/test/java/ch/jalu/configme/properties/PropertyInitializerTest.java

@@ -89,7 +89,7 @@ void shouldInstantiateBuilders() {
     }
 
     @Test
-    void shouldHaveAccessibleNoArgsConstructorForExtensions() {
+    void shouldHaveAccessibleNoArgConstructorForExtensions() {
         // given / when
         new PropertyInitializer() { };
 

src/test/java/ch/jalu/configme/samples/settingsholders/SettingsHolderWithInvalidConstants.java

@@ -23,7 +23,7 @@ public class SettingsHolderWithInvalidConstants implements SettingsHolder {
     private SettingsHolderWithInvalidConstants() {
     }
 
-    // used for test ensuring classes only have a sole no-args private constructor
+    // used for test ensuring classes only have a sole no-arg private constructor
     private SettingsHolderWithInvalidConstants(boolean other) {
     }
 

src/test/java/ch/jalu/configme/utils/SettingsHolderClassValidatorTest.java

@@ -203,7 +203,7 @@ void shouldThrowForClassWithoutPrivateConstructor() {
             () -> validator.validateClassesHaveHiddenNoArgConstructor(classes));
 
         // then
-        assertThat(e.getMessage(), equalTo("The following classes do not have a single no-args private constructor:"
+        assertThat(e.getMessage(), equalTo("The following classes do not have a single no-arg private constructor:"
             + "\n- ch.jalu.configme.samples.settingsholders.SettingsHolderWithEnumPropertyComments"
             + "\n- ch.jalu.configme.samples.settingsholders.SettingsHolderWithInvalidConstants"));
     }