fix(s3wal): 503 SlowDown during WAL recovery from S3#3198
Merged
superhx merged 2 commits intoAutoMQ:mainfrom Feb 6, 2026
Merged
fix(s3wal): 503 SlowDown during WAL recovery from S3#3198superhx merged 2 commits intoAutoMQ:mainfrom
superhx merged 2 commits intoAutoMQ:mainfrom
Conversation
Gezi-lzq
reviewed
Feb 4, 2026
s3stream/src/main/java/com/automq/stream/s3/operator/AwsObjectStorage.java
Outdated
Show resolved
Hide resolved
s3stream/src/main/java/com/automq/stream/s3/operator/AwsObjectStorage.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses broker crashes during startup/recovery when AWS S3 returns 503 SlowDown errors due to rate limiting. The fix implements two key changes: adding AWS SDK's built-in retry mechanism (RetryMode.STANDARD) for all S3 operations, and implementing custom retry logic specifically for delete operations.
Changes:
- Added RetryMode.STANDARD to AWS S3 client configuration for automatic retry with exponential backoff
- Implemented custom retry logic for S3 delete operations with throttling detection
- Added TimeUnit import to support retry scheduling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
s3stream/src/main/java/com/automq/stream/s3/operator/AwsObjectStorage.java
Outdated
Show resolved
Hide resolved
s3stream/src/main/java/com/automq/stream/s3/operator/AwsObjectStorage.java
Outdated
Show resolved
Hide resolved
s3stream/src/main/java/com/automq/stream/s3/operator/AwsObjectStorage.java
Outdated
Show resolved
Hide resolved
s3stream/src/main/java/com/automq/stream/s3/operator/AwsObjectStorage.java
Show resolved
Hide resolved
Contributor
|
LGTM |
Gezi-lzq
approved these changes
Feb 6, 2026
superhx
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3177
Problem
AutoMQ brokers crash during startup/recovery when AWS S3 returns 503 SlowDown error due to rate limiting.
Solution
Added
RetryMode.STANDARDto the AWS S3 client configuration which adds automatic retry with exponential backoff for S3 throttling errors.File:
s3stream/src/main/java/com/automq/stream/s3/operator/AwsObjectStorage.javaLine: 470
Also, retry logic for delete operations has been added.
Why STANDARD?
Testing
Results
Verification Commands
Broker Logs
AWS RetryStrategy documentation
Committer Checklist (excluded from commit message)