feat(binder): implement AvroValueAdapter and RecordBinder for Avro to Iceberg conversion #2744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gezi-lzq
requested review from
superhx,
1sonofqiu and
woshigaopp
as code owners
Gezi-lzq
force-pushed
the
feat/iceberg-binder
branch
2 times, most recently
from
16aabe8 to
30abf31
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new Avro to Iceberg conversion mechanism using the adapter pattern for improved performance and flexibility. The implementation includes lazy-evaluation Record views that convert field values only when accessed, avoiding upfront conversion overhead.
Key changes include:
- Introduction of TypeAdapter interface and abstract implementation for type conversion
- RecordBinder that creates lazy-evaluation Record views from Avro GenericRecords
- AvroValueAdapter with Avro-specific type handling for Utf8, EnumSymbol, and Fixed types
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| TypeAdapter.java | Interface for converting values between schema systems |
| AbstractTypeAdapter.java | Base implementation with common type conversion logic |
| AvroValueAdapter.java | Avro-specific type adapter implementation |
| RecordBinder.java | Factory creating lazy-evaluation Record views |
| AvroRecordBinderTest.java | Comprehensive test suite for all data type conversions |
| PerformanceComparisonTest.java | Performance comparison between RecordBinder and Visitor |
| PerformanceProfilingTest.java | Detailed profiling test for performance analysis |
core/src/test/java/kafka/automq/table/binder/PerformanceProfilingTest.java
Show resolved
Hide resolved
core/src/test/java/kafka/automq/table/binder/PerformanceProfilingTest.java
Show resolved
Hide resolved
core/src/test/java/kafka/automq/table/binder/PerformanceProfilingTest.java
Show resolved
Hide resolved
superhx
previously approved these changes
Aug 11, 2025
Gezi-lzq
changed the title
Gezi-lzq
changed the title
Gezi-lzq
changed the title
… Iceberg conversion
Gezi-lzq
force-pushed
the
feat/iceberg-binder
branch
from
ac5981a to
76fbbb6
Compare
superhx
reviewed
Aug 27, 2025
core/src/main/java/kafka/automq/table/binder/AvroValueAdapter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/kafka/automq/table/binder/AvroValueAdapter.java
Outdated
Show resolved
Hide resolved
superhx
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2743