Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Commit 20877eb

Browse files
authored
Merge pull request #99 from AutoMapper/jbogard-patch-1
Updating versions
2 parents 4daa3e7 + 17189c8 commit 20877eb

File tree

7 files changed

+44
-14
lines changed

7 files changed

+44
-14
lines changed

src/AutoMapper.Extensions.Microsoft.DependencyInjection/AutoMapper.Extensions.Microsoft.DependencyInjection.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<Description>AutoMapper extensions for ASP.NET Core</Description>
55
<Copyright>Copyright Jimmy Bogard</Copyright>
6-
<VersionPrefix>6.0.0</VersionPrefix>
6+
<VersionPrefix>6.1.0</VersionPrefix>
77
<Authors>Jimmy Bogard</Authors>
88
<TargetFrameworks>netstandard2.0</TargetFrameworks>
99
<AssemblyName>AutoMapper.Extensions.Microsoft.DependencyInjection</AssemblyName>
@@ -20,7 +20,7 @@
2020

2121
<ItemGroup>
2222
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="2.0.0" />
23-
<PackageReference Include="AutoMapper" Version="8.0.0" />
23+
<PackageReference Include="AutoMapper" Version="8.1.0" />
2424
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta-63102-01" PrivateAssets="All" />
2525
</ItemGroup>
2626

src/AutoMapper.Extensions.Microsoft.DependencyInjection/ServiceCollectionExtensions.cs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -85,19 +85,11 @@ private static IServiceCollection AddAutoMapperClasses(IServiceCollection servic
8585
.SelectMany(a => a.DefinedTypes)
8686
.ToArray();
8787

88-
var profileTypeInfo = typeof(Profile).GetTypeInfo();
89-
var profiles = allTypes
90-
.Where(t => profileTypeInfo.IsAssignableFrom(t) && !t.IsAbstract)
91-
.ToArray();
92-
9388
void ConfigAction(IServiceProvider serviceProvider, IMapperConfigurationExpression cfg)
9489
{
9590
configAction?.Invoke(serviceProvider, cfg);
9691

97-
foreach (var profile in profiles.Select(t => t.AsType()))
98-
{
99-
cfg.AddProfile(profile);
100-
}
92+
cfg.AddMaps(assembliesToScan);
10193
}
10294

10395
var openTypes = new[]

test/AutoMapper.Extensions.Microsoft.DependencyInjection.Tests/AppDomainResolutionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public void ShouldResolveConfiguration()
2828
[Fact]
2929
public void ShouldConfigureProfiles()
3030
{
31-
_provider.GetService<IConfigurationProvider>().GetAllTypeMaps().Length.ShouldBe(2);
31+
_provider.GetService<IConfigurationProvider>().GetAllTypeMaps().Length.ShouldBe(3);
3232
}
3333

3434
[Fact]

test/AutoMapper.Extensions.Microsoft.DependencyInjection.Tests/AssemblyResolutionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void ShouldResolveConfiguration()
3333
[Fact]
3434
public void ShouldConfigureProfiles()
3535
{
36-
_provider.GetService<IConfigurationProvider>().GetAllTypeMaps().Length.ShouldBe(2);
36+
_provider.GetService<IConfigurationProvider>().GetAllTypeMaps().Length.ShouldBe(3);
3737
}
3838

3939
[Fact]
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
using System;
2+
using Microsoft.Extensions.DependencyInjection;
3+
using Shouldly;
4+
using Xunit;
5+
6+
namespace AutoMapper.Extensions.Microsoft.DependencyInjection.Tests
7+
{
8+
public class AttributeTests
9+
{
10+
[Fact]
11+
public void Should_not_register_static_instance_when_configured()
12+
{
13+
IServiceCollection services = new ServiceCollection();
14+
services.AddAutoMapper(cfg => cfg.CreateMissingTypeMaps = false, typeof(Source3));
15+
16+
var serviceProvider = services.BuildServiceProvider();
17+
18+
var mapper = serviceProvider.GetService<IMapper>();
19+
20+
var source = new Source3 {Value = 3};
21+
22+
var dest = mapper.Map<Dest3>(source);
23+
24+
dest.Value.ShouldBe(source.Value);
25+
}
26+
}
27+
}

test/AutoMapper.Extensions.Microsoft.DependencyInjection.Tests/Profiles.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,17 @@ public class Dest2
2121
public int ConvertedValue { get; set; }
2222
}
2323

24+
public class Source3
25+
{
26+
public int Value { get; set; }
27+
}
28+
29+
[AutoMap(typeof(Source3))]
30+
public class Dest3
31+
{
32+
public int Value { get; set; }
33+
}
34+
2435
public class Profile1 : Profile
2536
{
2637
public Profile1()

test/AutoMapper.Extensions.Microsoft.DependencyInjection.Tests/TypeResolutionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public void ShouldResolveConfiguration()
2626
[Fact]
2727
public void ShouldConfigureProfiles()
2828
{
29-
_provider.GetService<IConfigurationProvider>().GetAllTypeMaps().Length.ShouldBe(2);
29+
_provider.GetService<IConfigurationProvider>().GetAllTypeMaps().Length.ShouldBe(3);
3030
}
3131

3232
[Fact]

0 commit comments

Comments
 (0)