Make the localization identical on the DCL auto-completion UI (#206)

Make the localization identical on the DCL auto-completion UI (#206)

Author: Sen-real

extension/src/completion/completionLibraryDcl.ts

@@ -77,8 +77,9 @@ export class CompletionLibraryDcl {
 
 	private generateDynamics() : void {
 		const localDialogStruct = localize("autolispext.commands.dclcompletion.primitive.dialog", "Generates a dialog structure");
+		const localTile = localize("autolispext.commands.dclcompletion.primitive.Tile", "Tile");
 		this.dclSnippets.set(SnippetKeys.DIALOG,
-			this.makeSnippet('dialog', localDialogStruct, 'Tile', `\${1:NAME} : dialog {\n\t$0\n}`, Kinds.TILE)
+			this.makeSnippet('dialog', localDialogStruct, localTile, `\${1:NAME} : dialog {\n\t$0\n}`, Kinds.TILE)
 		);
 
 		const localPrimitive = localize("autolispext.commands.dclcompletion.primitive", "Primitive");
@@ -113,6 +114,8 @@ export class CompletionLibraryDcl {
 	}
 
     private generateTiles() : void {
+        const localTile = localize("autolispext.commands.dclcompletion.primitive.Tile", "Tile");
+
         for (const key of AutoLispExt.WebHelpLibrary.dclTiles.keys()) {
 			const lowerKey = key.toLowerCase();
 			if (lowerKey === 'dialog') {
@@ -122,7 +125,7 @@ export class CompletionLibraryDcl {
             const def = AutoLispExt.WebHelpLibrary.dclTiles.get(key);
             const item = new CompletionItemDcl(def.id);
             item.kind = Kinds.TILE;
-			item.detail = 'Tile';
+			item.detail = localTile;
             item.sortText = `!${lowerKey}`; // The '!' helps elevate suggestions
             item.documentation = Annotation.asMarkdown(def);
 			item.insertText = def.id;
@@ -140,12 +143,14 @@ export class CompletionLibraryDcl {
 		// TODO: OS Filtering Technical debt
 		//       After the Lisp AutoComplete gets updated, then we can turn on the new setting for both document types.
 
+        const localAttr = localize("autolispext.commands.dclcompletion.primitive.Attribute", "Attribute");
+
         for (const key of AutoLispExt.WebHelpLibrary.dclAttributes.keys()) {
             const def = AutoLispExt.WebHelpLibrary.dclAttributes.get(key);
             const lowerKey = key.toLowerCase();
             const item = new CompletionItemDcl(def.id);
             item.kind = Kinds.ATTRIBUTE;
-			item.detail = 'Attribute';			
+			item.detail = localAttr;			
             item.sortText = `!!${lowerKey}`; // The '!!' helps elevate Attribute suggestions above Tile suggestions
             item.documentation = Annotation.asMarkdown(def);
 			item.insertText = def.id;
@@ -154,6 +159,8 @@ export class CompletionLibraryDcl {
     }
 
 	private generateEnums() : void {
+		const localEnum = localize("autolispext.commands.dclcompletion.primitive.Enum", "Enum");
+
 		for (const key of AutoLispExt.WebHelpLibrary.dclAttributes.keys()) {
 			const def = AutoLispExt.WebHelpLibrary.dclAttributes.get(key);
 			const lowerKey = key.toLowerCase();
@@ -173,7 +180,7 @@ export class CompletionLibraryDcl {
 				def.valueType.enums.forEach(name => {
 					const item = new CompletionItemDcl(name);
 					item.kind = Kinds.ENUM;
-					item.detail = 'Enum';
+					item.detail = localEnum;
 					item.sortText = name;
 					item.insertText = name;
 					types.push(item);

extension/src/completion/completionProviderDcl.ts

@@ -7,6 +7,10 @@ import {CompletionItemDcl} from "./completionItemDcl";
 import {AutoLispExt} from "../context";
 import {CompletionLibraryDcl, SnippetKeys} from "./completionLibraryDcl";
 import {Kinds} from './completionItemDcl';
+import * as nls from 'vscode-nls';
+
+const localize = nls.loadMessageBundle();
+
 
 // This file is responsible for determining what could potentially be suggested give the current context
 
@@ -105,10 +109,12 @@ function getApplicableAttributes(tile: DclTile, pos: Position) : Array<string> {
 function stringProcessing(atom: IDclFragment, directParent: IDclContainer, pos: Position, context: CompletionContext): Array<CompletionItemDcl> {
     const index = directParent.atoms.indexOf(atom);
     if (directParent.atoms[index + 1]?.symbol !== ';' && pos.character === atom.range.end.character - 1) {
+        const localPrimitive = localize("autolispext.commands.dclcompletion.provider.Primitive", "Primitive");
+        const localClosesStr = localize("autolispext.commands.dclcompletion.provider.ClosesString", "Closes the string");
         const result = new CompletionItemDcl(`${atom.symbol};`);
         result.insertText = `${atom.symbol};`;
-        result.detail = 'Primitive';
-        result.documentation = 'Closes the string';
+        result.detail = localPrimitive;
+        result.documentation = localClosesStr;
         result.range = atom.range;
         result.kind = Kinds.PRIMITIVE;
         return [result];

i18n/enu/out/completion/completionLibraryDcl.i18n.json

@@ -3,5 +3,8 @@
   "autolispext.commands.dclcompletion.primitive.dialog": "Generates a dialog structure",
   "autolispext.commands.dclcompletion.primitive.structure": "structural primitive",
   "autolispext.commands.dclcompletion.primitive.string": "string structure",
-  "autolispext.commands.dclcompletion.primitive.boolean": "boolean structure"
+  "autolispext.commands.dclcompletion.primitive.boolean": "boolean structure",
+  "autolispext.commands.dclcompletion.primitive.Enum": "Enum",
+  "autolispext.commands.dclcompletion.primitive.Attribute": "Attribute",
+  "autolispext.commands.dclcompletion.primitive.Tile": "Tile"
 }

i18n/enu/out/completion/completionProviderDcl.i18n.json

@@ -0,0 +1,4 @@
+{
+  "autolispext.commands.dclcompletion.provider.Primitive": "Primitive",
+  "autolispext.commands.dclcompletion.provider.ClosesString": "Closes the string"
+}