Implement AboutAppDialog in ShareScreen

Author: AdamGrzybkowski

homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareEvent.kt

@@ -5,4 +5,6 @@ internal sealed class ShareEvent {
     data class OnEmailSharingChanged(val isShared: Boolean) : ShareEvent()
     data class OnPhoneValueChanged(val value: String) : ShareEvent()
     data class OnPhoneSharingChanged(val isShared: Boolean) : ShareEvent()
+    data object OnAboutAppClicked : ShareEvent()
+    data object OnDismissAboutAppDialog : ShareEvent()
 }

homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareScreen.kt

@@ -15,6 +15,7 @@ import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.ViewModelStoreOwner
 import com.gravatar.app.design.theme.GravatarAppTheme
+import com.gravatar.app.homeUi.presentation.home.components.topbar.components.AboutAppDialog
 import com.gravatar.app.homeUi.presentation.home.share.components.ShareHeader
 import com.gravatar.app.homeUi.presentation.home.share.components.SharePrivateContactInfo
 import org.koin.androidx.compose.koinViewModel
@@ -46,7 +47,10 @@ internal fun ShareScreen(uiState: ShareUiState, onEvent: (ShareEvent) -> Unit) {
         ShareHeader(
             avatarUrl = uiState.avatarUrl.orEmpty(),
             modifier = Modifier
-                .fillMaxWidth()
+                .fillMaxWidth(),
+            onAboutAppClicked = {
+                onEvent(ShareEvent.OnAboutAppClicked)
+            }
         )
 
         SharePrivateContactInfo(
@@ -58,14 +62,21 @@ internal fun ShareScreen(uiState: ShareUiState, onEvent: (ShareEvent) -> Unit) {
             modifier = Modifier.padding(16.dp),
         )
     }
+
+    AboutAppDialog(
+        visible = uiState.isAboutAppDialogVisible,
+        onDismissRequest = {
+            onEvent(ShareEvent.OnDismissAboutAppDialog)
+        }
+    )
 }
 
 @Preview
 @Composable
 private fun ShareScreenPreview() {
     GravatarAppTheme {
         ShareScreen(
-            uiState = ShareUiState(),
+            uiState = ShareUiState(isAboutAppDialogVisible = false),
             onEvent = { }
         )
     }

homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareUiState.kt

@@ -5,12 +5,13 @@ import com.gravatar.restapi.models.Profile
 internal data class ShareUiState(
     val profile: Profile? = null,
     val avatarUrl: String? = null,
-    val privateContactInfo: PrivateContactInfo = PrivateContactInfo()
+    val isAboutAppDialogVisible: Boolean = false,
+    val privateContactInfo: PrivateContactInfo = PrivateContactInfo(),
 )
 
 internal data class PrivateContactInfo(
     val emailValue: String = "",
     val isEmailShared: Boolean = false,
     val phoneValue: String = "",
-    val isPhoneShared: Boolean = false
+    val isPhoneShared: Boolean = false,
 )

homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareViewModel.kt

@@ -62,6 +62,20 @@ internal class ShareViewModel(
                     )
                 }
             }
+            is ShareEvent.OnAboutAppClicked -> showAboutAppDialog()
+            is ShareEvent.OnDismissAboutAppDialog -> hideAboutAppDialog()
+        }
+    }
+
+    private fun showAboutAppDialog() {
+        _uiState.update { currentState ->
+            currentState.copy(isAboutAppDialogVisible = true)
+        }
+    }
+
+    private fun hideAboutAppDialog() {
+        _uiState.update { currentState ->
+            currentState.copy(isAboutAppDialogVisible = false)
         }
     }
 

homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/components/ShareHeader.kt

@@ -38,6 +38,7 @@ import com.gravatar.app.homeUi.presentation.home.profile.header.MENU_BUTTON_SIZE
 internal fun ShareHeader(
     avatarUrl: String,
     modifier: Modifier = Modifier,
+    onAboutAppClicked: () -> Unit = {},
 ) {
     var topBarMenuVisible by remember { mutableStateOf(false) }
 
@@ -92,6 +93,10 @@ internal fun ShareHeader(
                             anchorAlignment = Alignment.End,
                             offset = DpOffset(0.dp, 6.dp),
                             onDismissRequest = { topBarMenuVisible = false },
+                            onAboutAppClicked = {
+                                topBarMenuVisible = false
+                                onAboutAppClicked()
+                            }
                         )
                     }
                 }

homeUi/src/test/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareViewModelTest.kt

@@ -10,15 +10,17 @@ import io.mockk.every
 import io.mockk.mockk
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.MutableSharedFlow
-import kotlinx.coroutines.flow.flowOf
 import kotlinx.coroutines.test.StandardTestDispatcher
 import kotlinx.coroutines.test.advanceUntilIdle
 import kotlinx.coroutines.test.runTest
 import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import java.net.URI
+import java.net.URL
 
 @OptIn(ExperimentalCoroutinesApi::class)
 class ShareViewModelTest {
@@ -27,16 +29,19 @@ class ShareViewModelTest {
     @get:Rule
     var coroutineTestRule = CoroutineTestRule(testDispatcher)
 
+    private val getAvatarUrl: GetAvatarUrl = object : GetAvatarUrl {
+        override fun invoke() = avatarUrlFlow
+    }
     private val userRepository = mockk<UserRepository>()
+
     private lateinit var viewModel: ShareViewModel
 
+    private val avatarUrlFlow: MutableSharedFlow<URL?> = MutableSharedFlow()
     private val profileFlow: MutableSharedFlow<Profile?> = MutableSharedFlow()
-    private val getAvatarUrl = mockk<GetAvatarUrl>()
 
     @Before
     fun setup() {
         every { userRepository.getProfile() } returns profileFlow
-        every { getAvatarUrl.invoke() } returns flowOf(null)
         viewModel = ShareViewModel(userRepository, getAvatarUrl)
     }
 
@@ -120,6 +125,37 @@ class ShareViewModelTest {
         }
     }
 
+    @Test
+    fun `when OnAboutAppClicked event is triggered then isAboutAppDialogVisible is set to true`() = runTest {
+        // When
+        viewModel.onEvent(ShareEvent.OnAboutAppClicked)
+        advanceUntilIdle()
+
+        // Then
+        viewModel.uiState.test {
+            val state = awaitItem()
+            assertTrue(state.isAboutAppDialogVisible)
+        }
+    }
+
+    @Test
+    fun `when OnDismissAboutAppDialog event is triggered then isAboutAppDialogVisible is set to false`() = runTest {
+        // First show the dialog
+        viewModel.onEvent(ShareEvent.OnAboutAppClicked)
+        advanceUntilIdle()
+
+        // Verify dialog is visible
+        viewModel.uiState.test {
+            assertTrue(awaitItem().isAboutAppDialogVisible)
+
+            // When
+            viewModel.onEvent(ShareEvent.OnDismissAboutAppDialog)
+
+            // Then
+            assertFalse(awaitItem().isAboutAppDialogVisible)
+        }
+    }
+
     private fun createTestProfile() = Profile {
         hash = "test-hash"
         displayName = "Test User"