Performance/TaxonomyMetaInOptions: add support for handling PHP 8.0+ function calls using named parameters

Includes tests.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Performance/TaxonomyMetaInOptionsSniff.php

@@ -10,6 +10,7 @@
 namespace WordPressVIPMinimum\Sniffs\Performance;
 
 use PHP_CodeSniffer\Util\Tokens;
+use PHPCSUtils\Utils\PassedParameters;
 use WordPressCS\WordPress\AbstractFunctionParameterSniff;
 
 /**
@@ -78,13 +79,16 @@ class TaxonomyMetaInOptionsSniff extends AbstractFunctionParameterSniff {
 	 * @return void
 	 */
 	public function process_parameters( $stackPtr, $group_name, $matched_content, $parameters ) {
-		$openBracket = $this->phpcsFile->findNext( Tokens::$emptyTokens, $stackPtr + 1, null, true );
-
-		if ( $this->tokens[ $openBracket ]['code'] !== T_OPEN_PARENTHESIS ) {
+		$target_param = PassedParameters::getParameterFromStack( $parameters, 1, 'option' );
+		if ( $target_param === false ) {
+			// Missing (required) target parameter. Probably live coding, nothing to examine (yet). Bow out.
 			return;
 		}
 
-		$param_ptr = $this->phpcsFile->findNext( Tokens::$emptyTokens, $openBracket + 1, null, true );
+		$param_start = $target_param['start'];
+		$param_end   = ( $target_param['end'] + 1 ); // Add one to include the last token in the parameter in findNext searches.
+
+		$param_ptr = $this->phpcsFile->findNext( Tokens::$emptyTokens, $param_start, $param_end, true );
 
 		if ( $this->tokens[ $param_ptr ]['code'] === T_DOUBLE_QUOTED_STRING ) {
 			foreach ( $this->taxonomy_term_patterns as $taxonomy_term_pattern ) {

WordPressVIPMinimum/Tests/Performance/TaxonomyMetaInOptionsUnitTest.inc

@@ -53,3 +53,11 @@ get_option( /*comment*/ "taxonomy_rating_$tag_id" ); // NOK.
 UpDate_OPTION( 'taxonomy_rating_' . $category_id /*comment*/ , ); // NOK.
 \Get_Option( "taxonomy_rating_{$cat_id}" ); // NOK.
 add_option( 'taxonomy_rating_' . $obj->term_id ); // NOK.
+
+
+// Safeguard handling of function calls using PHP 8.0+ named parameters.
+get_option(default_value: false); // OK, well, not really, missing required $option param, but that's not the concern of this sniff.
+add_option(value: "$tag_id", option: 'option_name'); // OK.
+update_option(autoload: true, optin: "$tag_id", value: 10,); // OK, well, not really, typo in param name, but that's not the concern of the sniff.
+
+add_option(value: $value, option: "$tag_id" ); // Bad.

WordPressVIPMinimum/Tests/Performance/TaxonomyMetaInOptionsUnitTest.php

@@ -38,6 +38,7 @@ public function getWarningList() {
 			53 => 1,
 			54 => 1,
 			55 => 1,
+			63 => 1,
 		];
 	}
 }