AbstractArrayAssignmentRestrictions children: adjust for changes in received $val

The `$val` parameter received by the `callback()` method will no longer automatically have been stripped of quotes.

This adjusts the `callback()` methods of the sniff which extend the WPCS `AbstractArrayAssignmentRestrictions` sniff to take this into account.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Performance/NoPagingSniff.php

@@ -52,6 +52,6 @@ public function getGroups() {
 	public function callback( $key, $val, $line, $group ) {
 		$key = strtolower( $key );
 
-		return ( $key === 'nopaging' && ( $val === 'true' || $val === 1 ) );
+		return ( $key === 'nopaging' && ( $val === 'true' || $val === '1' ) );
 	}
 }

WordPressVIPMinimum/Sniffs/Performance/OrderByRandSniff.php

@@ -9,6 +9,7 @@
 
 namespace WordPressVIPMinimum\Sniffs\Performance;
 
+use PHPCSUtils\Utils\TextStrings;
 use WordPressCS\WordPress\AbstractArrayAssignmentRestrictionsSniff;
 
 /**
@@ -31,7 +32,7 @@ public function getGroups() {
 		return [
 			'orderby' => [
 				'type'    => 'error',
-				'message' => 'Detected forbidden query_var "%s" of "%s". Use vip_get_random_posts() instead.',
+				'message' => 'Detected forbidden query_var "%s" of %s. Use vip_get_random_posts() instead.',
 				'keys'    => [
 					'orderby',
 				],
@@ -50,6 +51,7 @@ public function getGroups() {
 	 * @return bool FALSE if no match, TRUE if matches.
 	 */
 	public function callback( $key, $val, $line, $group ) {
+		$val = TextStrings::stripQuotes( $val );
 		return strtolower( $val ) === 'rand';
 	}
 }

WordPressVIPMinimum/Sniffs/Performance/RegexpCompareSniff.php

@@ -7,6 +7,7 @@
 
 namespace WordPressVIPMinimum\Sniffs\Performance;
 
+use PHPCSUtils\Utils\TextStrings;
 use WordPressCS\WordPress\AbstractArrayAssignmentRestrictionsSniff;
 
 /**
@@ -45,6 +46,7 @@ public function getGroups() {
 	 * @return bool FALSE if no match, TRUE if matches.
 	 */
 	public function callback( $key, $val, $line, $group ) {
+		$val = TextStrings::stripQuotes( $val );
 		return ( strpos( $val, 'NOT REGEXP' ) === 0
 			|| strpos( $val, 'REGEXP' ) === 0
 		);