WAIT - VIPCS 4.0 | WIP | Various sniffs: fix property visibility

`public` properties in sniffs can be changed from within a PHPCS XML ruleset file.
A number of properties in VIPCS sniffs should never have been `public` to begin with and for most, the format of the property value (multi-level array) cannot be set from within a custom ruleset anyway.

This commit changes the visibility for these properties from `public` to `private`.

Related to issue 234

Note: the `TaxonomyMetaInOptionsSniff::$option_functions` property is not included in this commit as it is deprecated and will be removed.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Functions/CheckReturnValueSniff.php

@@ -28,7 +28,7 @@ class CheckReturnValueSniff extends Sniff {
 	 *
 	 * @var array<string, array<string>>
 	 */
-	public $catch = [
+	private $catch = [
 		'esc_url'          => [
 			'get_term_link',
 		],
@@ -52,7 +52,7 @@ class CheckReturnValueSniff extends Sniff {
 	 *
 	 * @var array<string, int|string>
 	 */
-	public $notFunctions = [
+	private $notFunctions = [
 		'foreach' => T_FOREACH,
 	];
 

WordPressVIPMinimum/Sniffs/Performance/TaxonomyMetaInOptionsSniff.php

@@ -37,7 +37,7 @@ class TaxonomyMetaInOptionsSniff extends AbstractFunctionParameterSniff {
 	 *
 	 * @var array<string>
 	 */
-	public $taxonomy_term_patterns = [
+	private $taxonomy_term_patterns = [
 		'category_id',
 		'cat_id',
 		'cat',

WordPressVIPMinimum/Sniffs/Variables/ServerVariablesSniff.php

@@ -23,7 +23,7 @@ class ServerVariablesSniff extends Sniff {
 	 *
 	 * @var array<string, array<string, bool>>
 	 */
-	public $restrictedVariables = [
+	private $restrictedVariables = [
 		'authVariables'           => [
 			'PHP_AUTH_USER' => true,
 			'PHP_AUTH_PW'   => true,