Merge pull request #647 from Automattic/remove_get_super_admin

RestrictedFunctionsSniff: Remove get_super_admins group

Author: rebeccahum

WordPress-VIP-Go/ruleset.xml

@@ -276,9 +276,6 @@
 	<rule ref="WordPressVIPMinimum.Variables.RestrictedVariables.user_meta__wpdb__usermeta">
 		<severity>0</severity>
 	</rule>
-	<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.get_super_admins_get_super_admins">
-		<severity>0</severity>
-	</rule>
 	<rule ref="Generic.PHP.DisallowShortOpenTag.EchoFound">
 		<severity>0</severity>
 	</rule>

WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php

@@ -43,13 +43,6 @@ public function getGroups() {
 					'opcache_get_configuration',
 				],
 			],
-			'get_super_admins' => [
-				'type'      => 'error',
-				'message'   => '`%s` is prohibited on the WordPress.com VIP platform.',
-				'functions' => [
-					'get_super_admins',
-				],
-			],
 			'internal' => [
 				'type'      => 'error',
 				'message'   => '`%1$s()` is for internal use only.',

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc

@@ -33,8 +33,8 @@ opcache_get_status(); // Error.
 opcache_get_status( false ); // Error.
 opcache_get_configuration(); // Error.
 
-get_super_admin(); // Ok - similarly-named function to get_super_admins().
-get_super_admins(); // Error.
+
+
 
 vip_irc(); // Ok - similarly-named function to wpcom_vip_irc().
 wpcom_vip_irc(); // Error.

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php

@@ -33,7 +33,6 @@ public function getErrorList() {
 			32  => 1,
 			33  => 1,
 			34  => 1,
-			37  => 1,
 			40  => 1,
 			43  => 1,
 			46  => 1,

WordPressVIPMinimum/ruleset-test.inc

@@ -315,7 +315,7 @@ opcache_compile_file( $var ); // Error.
 opcache_is_script_cached( 'test_script.php' ); // Error.
 opcache_get_status(); // Error.
 opcache_get_configuration(); // Error.
-get_super_admins(); // Error.
+
 wpcom_vip_irc(); // Error.
 flush_rewrite_rules(); // Error.
 $wp_rewrite->flush_rules(); // Error.

WordPressVIPMinimum/ruleset-test.php

@@ -88,7 +88,6 @@
 		315 => 1,
 		316 => 1,
 		317 => 1,
-		318 => 1,
 		319 => 1,
 		320 => 1,
 		321 => 1,