Security/EscapingVoidReturnFunctions: switch to using WPCS PrintingFunctionsTrait

Note: this does mean that the sniff will now also support a `public` `customPrintingFunctions` property which can be adjusted in a custom ruleset.

Co-authored-by: Gary Jones <[email protected]>

Author: jrfnl

WordPressVIPMinimum/Sniffs/Security/EscapingVoidReturnFunctionsSniff.php

@@ -9,17 +9,22 @@
 namespace WordPressVIPMinimum\Sniffs\Security;
 
 use PHP_CodeSniffer\Util\Tokens;
+use WordPressCS\WordPress\Helpers\PrintingFunctionsTrait;
 use WordPressVIPMinimum\Sniffs\Sniff;
 
 /**
  * Flag functions that don't return anything, yet are wrapped in an escaping function call.
  *
  * E.g. esc_html( _e( 'foo' ) );
  *
- *  @package VIPCS\WordPressVIPMinimum
+ * @package VIPCS\WordPressVIPMinimum
+ *
+ * @uses \WordPressCS\WordPress\Helpers\PrintingFunctionsTrait::$customPrintingFunctions
  */
 class EscapingVoidReturnFunctionsSniff extends Sniff {
 
+	use PrintingFunctionsTrait;
+
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
@@ -59,7 +64,7 @@ public function process_token( $stackPtr ) {
 			return;
 		}
 
-		if ( isset( $this->printingFunctions[ $this->tokens[ $next_token ]['content'] ] ) ) {
+		if ( $this->is_printing_function( $this->tokens[ $next_token ]['content'] ) ) {
 			$message = 'Attempting to escape `%s()` which is printing its output.';
 			$data    = [ $this->tokens[ $next_token ]['content'] ];
 			$this->phpcsFile->addError( $message, $stackPtr, 'Found', $data );