VIPMinimum ruleset: replace assignment-in-condition sniff

... which has been split.

Author: jrfnl

WordPress-VIP-Go/ruleset-test.inc

@@ -153,7 +153,7 @@ url_to_postid( $url ); // Warning + Message.
 wpcom_vip_old_slug_redirect(); // Ok.
 wp_old_slug_redirect(); // Warning.
 
-// WordPress.CodeAnalysis.AssignmentInCondition.Found
+// Generic.CodeAnalysis.AssignmentInCondition.Found
 if ($a = 123) { // Warning.
 }
 
@@ -572,3 +572,8 @@ $_SERVER["REMOTE_ADDR"]; // Error.
 <<<<<<< HEAD // Error.
 
 >>>>>>> // Error.
+
+<?php
+
+// WordPress.CodeAnalysis.AssignmentInTernaryCondition
+$var = ($a = 123) ? $a : 0; // Warning.

WordPress-VIP-Go/ruleset-test.php

@@ -233,6 +233,7 @@
 		540 => 1,
 		550 => 1,
 		556 => 1,
+		579 => 1,
 	],
 	'messages' => [
 		7   => [

WordPress-VIP-Go/ruleset.xml

@@ -179,7 +179,10 @@
 	<rule ref="Internal.LineEndings.Mixed">
 		<severity>1</severity>
 	</rule>
-	<rule ref="WordPress.CodeAnalysis.AssignmentInCondition.Found">
+	<rule ref="Generic.CodeAnalysis.AssignmentInCondition">
+		<severity>1</severity>
+	</rule>
+	<rule ref="WordPress.CodeAnalysis.AssignmentInTernaryCondition.FoundInTernaryCondition">
 		<severity>1</severity>
 	</rule>
 	<rule ref="WordPress.PHP.DiscouragedPHPFunctions.urlencode_urlencode">

WordPressVIPMinimum/ruleset-test.inc

@@ -76,7 +76,7 @@ $GLOBALS['wpdb'] = 'test'; // Error.
 if ( true == $true ) { // Warning.
 }
 
-// WordPress.CodeAnalysis.AssignmentInCondition
+// Generic.CodeAnalysis.AssignmentInCondition
 if ( $test = get_post( $post ) ) { // Warning.
 }
 
@@ -614,6 +614,9 @@ class MyClass {
 >>>>>>> // Error.
 <?php
 
+// WordPress.CodeAnalysis.AssignmentInTernaryCondition
+$var = ( $test = get_post( $post ) ) ? $test : ''; // Warning.
+
 // Squiz.WhiteSpace.SuperfluousWhitespace
 // Error. ?>
 

WordPressVIPMinimum/ruleset-test.php

@@ -197,7 +197,7 @@
 		597 => 1,
 		612 => 1,
 		614 => 1,
-		618 => 1,
+		621 => 1,
 	],
 	'warnings' => [
 		32  => 1,
@@ -290,6 +290,7 @@
 		559 => 1,
 		565 => 1,
 		589 => 1,
+		618 => 1,
 	],
 	'messages' => [
 		130 => [

WordPressVIPMinimum/ruleset.xml

@@ -39,7 +39,8 @@
 	<rule ref="Universal.Operators.StrictComparisons" phpcs-only="true">
 		<type>warning</type>
 	</rule>
-	<rule ref="WordPress.CodeAnalysis.AssignmentInCondition"/>
+	<rule ref="Generic.CodeAnalysis.AssignmentInCondition"/>
+	<rule ref="WordPress.CodeAnalysis.AssignmentInTernaryCondition"/>
 	<rule ref="WordPress.PHP.StrictInArray"/>
 	<rule ref="WordPress.PHP.DontExtract"/>
 	<rule ref="WordPress.WP.CronInterval">