Downgrade switch_to_blog to warning at sniff level

Author: rebeccahum

WordPress-VIP-Go/ruleset.xml

@@ -244,7 +244,6 @@
 		<severity>1</severity>
 	</rule>
 	<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.switch_to_blog_switch_to_blog">
-		<type>warning</type>
 		<severity>3</severity>
 	</rule>
 	<rule ref="WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn">

WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php

@@ -97,7 +97,7 @@ public function getGroups() {
 			],
 			// @link https://docs.wpvip.com/technical-references/code-review/vip-notices/#h-switch_to_blog
 			'switch_to_blog' => [
-				'type'      => 'error',
+				'type'      => 'warning',
 				'message'   => '%s() may not work as expected since it only changes the database context for the blog and does not load the plugins or theme of that site. Filters or hooks on the blog you are switching to will not run.',
 				'functions' => [
 					'switch_to_blog',

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc

@@ -53,7 +53,7 @@ db_delta(); // Ok - similarly-named function to dbDelta().
 dbDelta(); // Error.
 
 switch_blog(); // Ok - similarly-named function to switch_to_blog().
-switch_to_blog( $blogid ); // Error.
+switch_to_blog( $blogid ); // Warning.
 
 wpcom_vip_get_page_by_title(); // Ok - VIP recommended version of get_page_by_title().
 get_page_by_title( $page_title ); // Error.

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php

@@ -40,7 +40,6 @@ public function getErrorList() {
 			46  => 1,
 			50  => 1,
 			53  => 1,
-			56  => 1,
 			59  => 1,
 			62  => 1,
 			75  => 1,
@@ -120,6 +119,7 @@ public function getErrorList() {
 	 */
 	public function getWarningList() {
 		return [
+			56  => 1,
 			110 => 1,
 			111 => 1,
 			114 => 1,

WordPressVIPMinimum/ruleset-test.inc

@@ -321,7 +321,7 @@ flush_rewrite_rules(); // Error.
 $wp_rewrite->flush_rules(); // Error.
 attachment_url_to_postid( $url ); // Error.
 dbDelta(); // Error.
-switch_to_blog( $blogid ); // Error.
+switch_to_blog( $blogid ); // Warning.
 get_page_by_title( $page_title ); // Error.
 url_to_postid( $url ); // Error.
 \add_role(); // Error.

WordPressVIPMinimum/ruleset-test.php

@@ -95,7 +95,6 @@
 		321 => 1,
 		322 => 1,
 		323 => 1,
-		324 => 1,
 		325 => 1,
 		326 => 1,
 		327 => 1,
@@ -261,6 +260,7 @@
 		288 => 1,
 		293 => 1,
 		294 => 1,
+		324 => 1,
 		396 => 1,
 		397 => 1,
 		398 => 1,