NOTES OrderByRandSniff

jrfnl · jrfnl · commit 8dc21bb44952 · 2025-07-30T15:58:06.000+02:00
diff --git a/WordPressVIPMinimum/Sniffs/Performance/OrderByRandSniff.php b/WordPressVIPMinimum/Sniffs/Performance/OrderByRandSniff.php
@@ -49,6 +49,11 @@ public function getGroups() {
 	 */
 	public function callback( $key, $val, $line, $group ) {
 		$val = TextStrings::stripQuotes( $val );
+/*
+TODO:
+- check strtolower($val)
+   => could be that WP handles this in a case-insensitive manner internally, but that needs checking
+*/
 		return strtolower( $val ) === 'rand';
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,11 @@ public function getGroups() {`
`49`	`49`	`*/`
`50`	`50`	`public function callback( $key, $val, $line, $group ) {`
`51`	`51`	`$val = TextStrings::stripQuotes( $val );`
	`52`	`+/*`
	`53`	`+TODO:`
	`54`	`+- check strtolower($val)`
	`55`	`+ => could be that WP handles this in a case-insensitive manner internally, but that needs checking`
	`56`	`+*/`
`52`	`57`	`return strtolower( $val ) === 'rand';`
`53`	`58`	`}`
`54`	`59`	`}`