NOTES/LATER LowExpiryCacheTimeSniff

Author: jrfnl

WordPressVIPMinimum/Sniffs/Performance/LowExpiryCacheTimeSniff.php

@@ -24,6 +24,11 @@
  */
 class LowExpiryCacheTimeSniff extends AbstractFunctionParameterSniff {
 
+// TODO: switch to PHPCSUtils version of AbstractFunctionParameterSniff once available.
+// Have the namespace + use tracker available for the constant check
+// Also for the function check as per #408
+// Use Collections::nameTokens() to handle constant better for PHP 8.0/PHPCS 4.0.
+
 	/**
 	 * The group name for this group of functions.
 	 *

WordPressVIPMinimum/Tests/Performance/LowExpiryCacheTimeUnitTest.1.inc

@@ -159,3 +159,9 @@ wp_cache_replace($key, expire: 400, group: $group, data: 100,); // OK.
 
 wp_cache_replace($key, $data, expire: 100 ); // Bad.
 wp_cache_replace(expire: 100, data: $data, key: $group); // Bad.
+
+// Test with constants for which the value is known.
+wp_cache_set( 'test', $data, $group, PHP_INT_MAX ); // OK.
+wp_cache_set( 'test', $data, $group, PHP_INT_MIN ); // Bad.
+wp_cache_set( 'test', $data, $group, PHP_FLOAT_MAX ); // OK.
+wp_cache_set( 'test', $data, $group, PHP_FLOAT_MIN ); // Bad.