WAIT - VIPCS 4.0 | Security/ProperEscapingFunction: remove deprecated properties & methods

Follow up on 670

Part of 849

Author: jrfnl

WordPressVIPMinimum/Sniffs/Security/ProperEscapingFunctionSniff.php

@@ -57,39 +57,6 @@ class ProperEscapingFunctionSniff extends Sniff {
 		T_NS_SEPARATOR       => T_NS_SEPARATOR,
 	];
 
-	/**
-	 * List of attributes associated with url outputs.
-	 *
-	 * @deprecated 2.3.1 Currently unused by the sniff, but needed for
-	 *                   for public methods which extending sniffs may be
-	 *                   relying on.
-	 *
-	 * @var array<string>
-	 */
-	private $url_attrs = [
-		'href',
-		'src',
-		'url',
-		'action',
-	];
-
-	/**
-	 * List of syntaxes for inside attribute detection.
-	 *
-	 * @deprecated 2.3.1 Currently unused by the sniff, but needed for
-	 *                   for public methods which extending sniffs may be
-	 *                   relying on.
-	 *
-	 * @var array<string>
-	 */
-	private $attr_endings = [
-		'=',
-		'="',
-		"='",
-		"=\\'",
-		'=\\"',
-	];
-
 	/**
 	 * Keep track of whether or not we're currently in the first statement of a short open echo tag.
 	 *
@@ -224,48 +191,6 @@ public function process_token( $stackPtr ) {
 		}
 	}
 
-	/**
-	 * Tests whether provided string ends with open attribute which expects a URL value.
-	 *
-	 * @deprecated 2.3.1
-	 *
-	 * @param string $content Haystack in which we look for an open attribute which exects a URL value.
-	 *
-	 * @return bool True if string ends with open attribute which expects a URL value.
-	 */
-	public function attr_expects_url( $content ) {
-		$attr_expects_url = false;
-		foreach ( $this->url_attrs as $attr ) {
-			foreach ( $this->attr_endings as $ending ) {
-				if ( $this->endswith( $content, $attr . $ending ) === true ) {
-					$attr_expects_url = true;
-					break;
-				}
-			}
-		}
-		return $attr_expects_url;
-	}
-
-	/**
-	 * Tests whether provided string ends with open HMTL attribute.
-	 *
-	 * @deprecated 2.3.1
-	 *
-	 * @param string $content Haystack in which we look for open HTML attribute.
-	 *
-	 * @return bool True if string ends with open HTML attribute.
-	 */
-	public function is_html_attr( $content ) {
-		$is_html_attr = false;
-		foreach ( $this->attr_endings as $ending ) {
-			if ( $this->endswith( $content, $ending ) === true ) {
-				$is_html_attr = true;
-				break;
-			}
-		}
-		return $is_html_attr;
-	}
-
 	/**
 	 * Tests whether an attribute escaping function is being used outside of an HTML tag.
 	 *