RestrictedVariables: remove usermeta related errors

Includes:
* Removing severity change related to this from the VIP Go ruleset.
* Removing the sniff tests related to these.
* Removing the ruleset tests related to these.

Partially fixes 614

Note: "removed" test lines have replaced with blank lines to prevent having to adjust the line numbers for all test after it in the "expected errors/warnings" arrays.

Author: jrfnl

WordPress-VIP-Go/ruleset-test.inc

@@ -296,8 +296,8 @@ if ( isset( $_GET['migSource'] ) && wp_verify_nonce( sanitize_text_field( $_GET[
 
 
 
-// WordPressVIPMinimum.Variables.RestrictedVariables.user_meta__wpdb__usermeta
-$query = "SELECT * FROM $wpdb->usermeta"; // Ok.
+
+
 
 // WordPressVIPMinimum.Functions.RestrictedFunctions.site_option_delete_site_option
 delete_site_option( $foo ); // Ok.

WordPress-VIP-Go/ruleset.xml

@@ -261,9 +261,6 @@
 		<!-- We are silencing this one because VIP Go does not use Batcache-->
 		<severity>0</severity>
 	</rule>
-	<rule ref="WordPressVIPMinimum.Variables.RestrictedVariables.user_meta__wpdb__usermeta">
-		<severity>0</severity>
-	</rule>
 	<rule ref="Generic.PHP.DisallowShortOpenTag.EchoFound">
 		<severity>0</severity>
 	</rule>

WordPressVIPMinimum/Sniffs/Variables/RestrictedVariablesSniff.php

@@ -39,10 +39,9 @@ public function getGroups() {
 		return [
 			'user_meta' => [
 				'type'        => 'error',
-				'message'     => 'Usage of users/usermeta tables is highly discouraged in VIP context, For storing user additional user metadata, you should look at User Attributes.',
+				'message'     => 'Usage of users tables is highly discouraged in VIP context',
 				'object_vars' => [
 					'$wpdb->users',
-					'$wpdb->usermeta',
 				],
 			],
 			'session' => [

WordPressVIPMinimum/Tests/Variables/RestrictedVariablesUnitTest.inc

@@ -4,9 +4,9 @@ $query = "SELECT * FROM $wpdb->users"; // Error.
 
 $wp_db->update( $wpdb->users, array( 'displayname' => 'Kanobe!' ), array( 'ID' => 1 ) ); // Error.
 
-$query = "SELECT * FROM $wpdb->usermeta"; // Error.
 
-$wp_db->update( $wpdb->usermeta, array( 'meta_value' => 'bar!' ), array( 'user_id' => 1, 'meta_key' => 'foo' ) ); // Error.
+
+
 
 $query = "SELECT * FROM $wpdb->posts"; // Ok.
 
@@ -20,7 +20,7 @@ $y = $_SERVER['REQUEST_URI']; // Ok.
 
 // Error.
 $query = <<<EOD
-SELECT * FROM $wpdb->usermeta
+SELECT * FROM $wpdb->users
 EOD;
 
 // Warning
@@ -29,7 +29,7 @@ Your user-agent is {$_SERVER['HTTP_USER_AGENT']}
 EOD;
 
 // phpcs:set WordPressVIPMinimum.Variables.RestrictedVariables exclude[] user_meta
-$query = "SELECT * FROM $wpdb->usermeta"; // Ok, excluded.
+$query = "SELECT * FROM $wpdb->users"; // Ok, excluded.
 
 // phpcs:set WordPressVIPMinimum.Functions.RestrictedFunctions exclude[]
 

WordPressVIPMinimum/Tests/Variables/RestrictedVariablesUnitTest.php

@@ -30,8 +30,6 @@ public function getErrorList() {
 		return [
 			3  => 1,
 			5  => 1,
-			7  => 1,
-			9  => 1,
 			23 => 1,
 			36 => 1,
 			37 => 1,