Skip to content

Commit fe60d9f

Browse files
authored
Merge pull request #485 from Automattic/fix/ruleset-tests
Ruleset Tests: Avoid issue with trigger_error()
2 parents e1d50c7 + 2c30904 commit fe60d9f

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

WordPress-VIP-Go/ruleset-test.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ $query_args = array(
510510
// WordPressVIPMinimum.Security.EscapingVoidReturnFunctions.Found
511511
esc_js( _deprecated_argument() ); // Error.
512512
esc_js( _deprecated_constructor() ); // Error.
513-
esc_js( _deprecated_file() ); // Error.
513+
// esc_js( _deprecated_file() ); // Error.
514514
esc_js( _deprecated_function() ); // Error.
515515
esc_js( _deprecated_hook() ); // Error.
516516
esc_js( _doing_it_wrong() ); // Error.

WordPress-VIP-Go/ruleset-test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
507 => 1,
9999
511 => 1,
100100
512 => 1,
101-
513 => 1,
101+
// 513 => 1,
102102
514 => 1,
103103
515 => 1,
104104
516 => 1,

WordPressVIPMinimum/ruleset-test.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ $output = shell_exec( 'ls -lart' ); // Error.
180180
var_dump(); // Warning.
181181
var_export(); // Warning.
182182
print_r(); // Warning.
183-
trigger_error(); // Warning.
183+
// trigger_error(); // Warning.
184184
set_error_handler(); // Warning.
185185
debug_backtrace(); // Warning.
186186
debug_print_backtrace(); // Warning.
@@ -508,7 +508,7 @@ $query_args = array(
508508
// WordPressVIPMinimum.Security.EscapingVoidReturnFunctions.Found
509509
esc_js( _deprecated_argument() ); // Error.
510510
esc_js( _deprecated_constructor() ); // Error.
511-
esc_js( _deprecated_file() ); // Error.
511+
// esc_js( _deprecated_file() ); // Error.
512512
esc_js( _deprecated_function() ); // Error.
513513
esc_js( _deprecated_hook() ); // Error.
514514
esc_js( _doing_it_wrong() ); // Error.

WordPressVIPMinimum/ruleset-test.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
505 => 1,
178178
509 => 1,
179179
510 => 1,
180-
511 => 1,
180+
// 511 => 1,
181181
512 => 1,
182182
513 => 1,
183183
514 => 1,
@@ -235,7 +235,7 @@
235235
180 => 1,
236236
181 => 1,
237237
182 => 1,
238-
183 => 1,
238+
// 183 => 1,
239239
184 => 1,
240240
185 => 1,
241241
186 => 1,

0 commit comments

Comments
 (0)