Add error handling for edit/ajax requests where a required parameter is missing

If we're performing an edit action via ajax, and one of the required parameters is missing, we can provide a WP Error object with a message that contains the missing parameter. We then return the error message to the front end via die(), which kills the ajax request as well and allows for another attempt.

Author: jeremyfelt

ad-code-manager.php

@@ -236,7 +236,11 @@ function handle_admin_action() {
 				else
 					$id = $this->edit_ad_code( $id, $ad_code_vals );
 				if ( is_wp_error( $id ) ) {
-					$message = 'error-adding-editing-ad-code';
+					// We can die with an error if this is an edit/ajax request
+					if ( isset( $id->errors['edit-error'][0] ) )
+						die( '<div class="error">' . $id->errors['edit-error'][0] . '</div>' );
+					else
+						$message = 'error-adding-editing-ad-code';
 					break;
 				}
 				$new_conditionals = array();
@@ -433,10 +437,9 @@ function create_ad_code( $ad_code = array() ) {
 	 */
 	function edit_ad_code( $ad_code_id, $ad_code = array()) {
 		foreach ( $this->current_provider->ad_code_args as $arg ) {
-			// We shouldn't update an ad code,
-			// If any of required fields is not set
+			// If a required argument is not set, we return an error message with the missing parameter
 			if ( ! $ad_code[$arg['key']] && $arg['required'] === true  ) {
-				return new WP_Error();
+				return new WP_Error( 'edit-error', 'Error updating ad code, a parameter for ' . esc_html( $arg['key'] ) . ' is required.' );
 			}
 		}
 		if ( 0 !== $ad_code_id ) {