fix: validate unique tag IDs for DFP Async provider

DFP Async uses the tag_id field as a div ID in the rendered HTML. When
two ad codes share the same tag_id, Google's ad serving becomes confused
because the same element ID appears multiple times on the page.

This adds validation that prevents saving ad codes with duplicate tag_id
values. The implementation uses a new 'acm_validate_ad_code' filter that
providers can hook into for custom validation, keeping the solution
extensible for other providers that may need similar checks.

Validation errors are now displayed via a notice at the top of the page
using a transient to pass the error message through the redirect.

Fixes #69

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: GaryJones

src/Providers/class-doubleclick-for-publishers-async.php

@@ -100,6 +100,7 @@ public function __construct() {
 
 		add_filter( 'acm_ad_code_args', array( $this, 'filter_ad_code_args' ) );
 		add_filter( 'acm_output_html', array( $this, 'filter_output_html' ), 10, 2 );
+		add_filter( 'acm_validate_ad_code', array( $this, 'validate_unique_tag_id' ), 10, 4 );
 
 		add_filter( 'acm_display_ad_codes_without_conditionals', '__return_true' );
 
@@ -167,11 +168,7 @@ public function filter_output_html( $output_html, $tag_id ) {
 					$tt               = $tag['url_vars'];
 					$matching_ad_code = $ad_code_manager->get_matching_ad_code( $tag['tag'] );
 					if ( ! empty( $matching_ad_code ) ) {
-						// @todo There might be a case when there are two tags registered with the same dimensions
-						// and the same tag id ( which is just a div id ). This confuses DFP Async, so we need to make sure
-						// that tags are unique
-
-						// Parse ad tags to output flexible unit dimensions
+						// Parse ad tags to output flexible unit dimensions.
 						$unit_sizes = $this->parse_ad_tag_sizes( $tt );
 
 						?>
@@ -235,6 +232,78 @@ public function parse_ad_tag_sizes( $url_vars ) {
 		return $unit_sizes_output;
 	}
 
+	/**
+	 * Validate that the tag_id is unique for DFP Async.
+	 *
+	 * DFP Async uses the tag_id as a div ID, so each tag_id must be unique
+	 * to prevent conflicts when multiple ads are rendered on the same page.
+	 *
+	 * @since 0.8.0
+	 *
+	 * @param true|WP_Error $valid        Current validation state.
+	 * @param array         $ad_code_vals The ad code values being saved.
+	 * @param int           $id           The ad code ID (0 for new ad codes).
+	 * @param string        $method       The method being performed ('add' or 'edit').
+	 * @return true|WP_Error True if valid, WP_Error if tag_id is not unique.
+	 */
+	public function validate_unique_tag_id( $valid, $ad_code_vals, $id, $method ) {
+		// If already invalid, don't override the error.
+		if ( is_wp_error( $valid ) ) {
+			return $valid;
+		}
+
+		// Check if tag_id is provided.
+		if ( empty( $ad_code_vals['tag_id'] ) ) {
+			return $valid;
+		}
+
+		global $ad_code_manager;
+
+		$tag_id      = $ad_code_vals['tag_id'];
+		$existing_id = $this->find_ad_code_by_tag_id( $tag_id );
+
+		// If no existing ad code with this tag_id, it's valid.
+		if ( ! $existing_id ) {
+			return true;
+		}
+
+		// If editing and the existing ad code is the same one we're editing, it's valid.
+		if ( 'edit' === $method && $existing_id === $id ) {
+			return true;
+		}
+
+		return new WP_Error(
+			'duplicate-tag-id',
+			sprintf(
+				/* translators: %s: the duplicate tag ID */
+				__( 'The Tag ID "%s" is already in use. Each Tag ID must be unique to prevent conflicts with DFP Async.', 'ad-code-manager' ),
+				esc_html( $tag_id )
+			)
+		);
+	}
+
+	/**
+	 * Find an ad code by its tag_id.
+	 *
+	 * @since 0.8.0
+	 *
+	 * @param string $tag_id The tag_id to search for.
+	 * @return int|false The ad code post ID if found, false otherwise.
+	 */
+	protected function find_ad_code_by_tag_id( $tag_id ) {
+		global $ad_code_manager;
+
+		$ad_codes = $ad_code_manager->get_ad_codes();
+
+		foreach ( $ad_codes as $ad_code ) {
+			if ( isset( $ad_code['url_vars']['tag_id'] ) && $ad_code['url_vars']['tag_id'] === $tag_id ) {
+				return $ad_code['post_id'];
+			}
+		}
+
+		return false;
+	}
+
 }
 
 class Doubleclick_For_Publishers_Async_ACM_WP_List_Table extends ACM_WP_List_Table {

src/class-ad-code-manager.php

@@ -275,6 +275,32 @@ function handle_admin_action() {
 				foreach ( $this->current_provider->ad_code_args as $arg ) {
 					$ad_code_vals[ $arg['key'] ] = sanitize_text_field( $_REQUEST['acm-column'][ $arg['key'] ] ?? '' );
 				}
+
+				/**
+				 * Filter to validate ad code data before saving.
+				 *
+				 * Providers can hook into this filter to perform custom validation.
+				 * Return a WP_Error to prevent saving and display an error message.
+				 *
+				 * @since 0.8.0
+				 *
+				 * @param true|WP_Error $valid        True if valid, WP_Error if validation fails.
+				 * @param array         $ad_code_vals The ad code values being saved.
+				 * @param int           $id           The ad code ID (0 for new ad codes).
+				 * @param string        $method       The method being performed ('add' or 'edit').
+				 */
+				$validation_result = apply_filters( 'acm_validate_ad_code', true, $ad_code_vals, $id, $method );
+
+				if ( is_wp_error( $validation_result ) ) {
+					if ( isset( $_REQUEST['doing_ajax'] ) && sanitize_text_field( $_REQUEST['doing_ajax'] ) ) {
+						die( '<div class="error">' . esc_html( $validation_result->get_error_message() ) . '</div>' );
+					}
+					// Store the error message in a transient for display after redirect.
+					set_transient( 'acm_validation_error_' . get_current_user_id(), $validation_result->get_error_message(), 30 );
+					$message = 'validation-error';
+					break;
+				}
+
 				if ( 'add' === $method ) {
 					$id = $this->create_ad_code( $ad_code_vals );
 				} else {

views/ad-code-manager.tpl.php

@@ -7,6 +7,9 @@
 	<h1><?php echo esc_html( get_admin_page_title() ); ?></h1>
 	<?php
 	if ( isset( $_REQUEST['message'] ) ) {
+		$message_text  = '';
+		$message_class = 'updated';
+
 		switch ( $_REQUEST['message'] ) {
 			case 'ad-code-added':
 				$message_text = __( 'Ad code created.', 'ad-code-manager' );
@@ -20,12 +23,20 @@
 			case 'options-saved':
 				$message_text = __( 'Options saved.', 'ad-code-manager' );
 				break;
+			case 'validation-error':
+				$transient_key = 'acm_validation_error_' . get_current_user_id();
+				$message_text  = get_transient( $transient_key );
+				if ( $message_text ) {
+					delete_transient( $transient_key );
+					$message_class = 'error';
+				}
+				break;
 			default:
 				$message_text = '';
 				break;
 		}
 		if ( '' !== $message_text ) {
-			echo '<div class="message updated"><p>' . esc_html( $message_text ) . '</p></div>';
+			echo '<div class="notice notice-' . esc_attr( $message_class ) . '"><p>' . esc_html( $message_text ) . '</p></div>';
 		}
 	}
 	?>