Skip to content

Commit 7de4965

Browse files
dhasilvamatticbot
authored andcommitted
Forms: Fix combobox dropdown occlusion with z-index (#46401)
* combobox containers/wrappers need to raise z-index to avoid oclusion by other elements * changelog * reset animated label so it doesn't step on top of dropdowns * Remove redundant tabindex Co-authored-by: Copilot <[email protected]> * typo Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/20470809130 Upstream-Ref: Automattic/jetpack@d9f4da0
1 parent 1a0e9ea commit 7de4965

File tree

10 files changed

+17
-8
lines changed

10 files changed

+17
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ This is an alpha version! The changes listed here are not final.
1717
- Update radio button styling to use ::before pseudo-element approach for consistency with checkboxes
1818

1919
### Fixed
20+
- Fixed combobox dropdown occlusion by adding z-index when open
2021
- Forms: don't allow ::after pseudo element manipulation on Jetpack Forms radio and checkbox input elements
2122
- Forms: update 'Learn more' link in form notification settings.
2223

dist/blocks/editor.asset.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<?php return array('dependencies' => array('jetpack-connection', 'jetpack-script-data', 'lodash', 'react', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-jp-i18n-loader', 'wp-notices', 'wp-plugins', 'wp-polyfill', 'wp-primitives', 'wp-url'), 'version' => '6a0fa763dd521c230507');
1+
<?php return array('dependencies' => array('jetpack-connection', 'jetpack-script-data', 'lodash', 'react', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-jp-i18n-loader', 'wp-notices', 'wp-plugins', 'wp-polyfill', 'wp-primitives', 'wp-url'), 'version' => '78cad461d58cad35d98d');

dist/blocks/editor.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/blocks/editor.rtl.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/contact-form/css/combobox.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/contact-form/css/combobox.rtl.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/contact-form/css/grunion-rtl.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/contact-form/css/grunion.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/contact-form/css/combobox.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,14 @@
166166
color: currentColor;
167167
}
168168

169+
// input wrappers with combobox open should raise to avoid occlusion
170+
.contact-form .wp-block-jetpack-input-wrap {
171+
172+
&:has(.is-combobox-open) {
173+
z-index: 2;
174+
}
175+
}
176+
169177
// Editor styles
170178
.wp-block .jetpack-custom-combobox {
171179

src/contact-form/css/grunion.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -914,7 +914,7 @@ on production builds, the attributes are being reordered, causing side-effects
914914
margin: 0;
915915
transform: translateY(-50%);
916916
transition: translatey 150ms cubic-bezier(0.4, 0, 0.2, 1);
917-
z-index: 2;
917+
z-index: 1;
918918
}
919919

920920
.contact-form .is-style-animated .grunion-field-wrap .grunion-label-text {

0 commit comments

Comments
 (0)