Skip to content

Commit 2f4ef1c

Browse files
authored
changelog (#45691)
1 parent 3f2f2d3 commit 2f4ef1c

File tree

2 files changed

+38
-32
lines changed

2 files changed

+38
-32
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Significance: patch
2+
Type: fixed
3+
4+
Forms: fix react error due to nesting tr as direct descendant of table, needs tbody

projects/packages/forms/src/dashboard/components/response-view/body.tsx

Lines changed: 34 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -455,40 +455,42 @@ const ResponseViewBody = ( {
455455

456456
<div className="jp-forms__inbox-response-meta">
457457
<table>
458-
<tr>
459-
<th>{ __( 'Date:', 'jetpack-forms' ) }</th>
460-
<td>
461-
{ sprintf(
462-
/* Translators: %1$s is the date, %2$s is the time. */
463-
__( '%1$s at %2$s', 'jetpack-forms' ),
464-
dateI18n( getDateSettings().formats.date, response.date ),
465-
dateI18n( getDateSettings().formats.time, response.date )
466-
) }
467-
</td>
468-
</tr>
469-
<tr>
470-
<th>{ __( 'Source:', 'jetpack-forms' ) }</th>
471-
<td>
472-
<ExternalLink href={ response.entry_permalink }>
473-
{ decodeEntities( response.entry_title ) || getPath( response ) }
474-
</ExternalLink>
475-
</td>
476-
</tr>
477-
<tr>
478-
<th>{ __( 'IP address:', 'jetpack-forms' ) }&nbsp;</th>
479-
<td>
480-
<Tooltip text={ __( 'Lookup IP address', 'jetpack-forms' ) }>
481-
{ response.country_code && (
482-
<span className="jp-forms__inbox-response-meta-country-flag response-country-flag">
483-
{ getCountryFlagEmoji( response.country_code ) }
484-
</span>
458+
<tbody>
459+
<tr>
460+
<th>{ __( 'Date:', 'jetpack-forms' ) }</th>
461+
<td>
462+
{ sprintf(
463+
/* Translators: %1$s is the date, %2$s is the time. */
464+
__( '%1$s at %2$s', 'jetpack-forms' ),
465+
dateI18n( getDateSettings().formats.date, response.date ),
466+
dateI18n( getDateSettings().formats.time, response.date )
485467
) }
486-
<ExternalLink href={ getRedirectUrl( 'ip-lookup', { path: response.ip } ) }>
487-
{ response.ip }
468+
</td>
469+
</tr>
470+
<tr>
471+
<th>{ __( 'Source:', 'jetpack-forms' ) }</th>
472+
<td>
473+
<ExternalLink href={ response.entry_permalink }>
474+
{ decodeEntities( response.entry_title ) || getPath( response ) }
488475
</ExternalLink>
489-
</Tooltip>
490-
</td>
491-
</tr>
476+
</td>
477+
</tr>
478+
<tr>
479+
<th>{ __( 'IP address:', 'jetpack-forms' ) }&nbsp;</th>
480+
<td>
481+
<Tooltip text={ __( 'Lookup IP address', 'jetpack-forms' ) }>
482+
{ response.country_code && (
483+
<span className="jp-forms__inbox-response-meta-country-flag response-country-flag">
484+
{ getCountryFlagEmoji( response.country_code ) }
485+
</span>
486+
) }
487+
<ExternalLink href={ getRedirectUrl( 'ip-lookup', { path: response.ip } ) }>
488+
{ response.ip }
489+
</ExternalLink>
490+
</Tooltip>
491+
</td>
492+
</tr>
493+
</tbody>
492494
</table>
493495
</div>
494496

0 commit comments

Comments
 (0)