Forms: Fix terms consent label colon issue (#45509)

* Remove period from labels on submission

The Terms consent block has a period in its label and when we render the
form submission we add a colon at the end which then renders as `.:`.
I'm trimming the period at the end before inserting the colon.`

* changelog

* Fix Terms consent period colon issue frontend side

Fix it also in the frontend for the ajax success response case.

Author: vianasw

projects/packages/forms/changelog/fix-form-consent-label-colon-issue

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Forms: strip period from Terms submission label on the post-submission page.

projects/packages/forms/src/contact-form/class-contact-form.php

@@ -2600,7 +2600,8 @@ function ( $json_str ) {
 	 */
 	private static function maybe_add_colon_to_label( $label ) {
 		$formatted_label = $label ? $label : '';
-		$formatted_label = str_ends_with( $formatted_label, '?' ) ? $formatted_label : rtrim( $formatted_label, ':' ) . ':';
+		// Special case for the Terms consent field block which a period after the label.
+		$formatted_label = str_ends_with( $formatted_label, '?' ) ? $formatted_label : rtrim( $formatted_label, ':.' ) . ':';
 
 		return $formatted_label;
 	}

projects/packages/forms/src/modules/form/view.js

@@ -103,8 +103,10 @@ const maybeAddColonToLabel = label => {
 	if ( ! formattedLabel ) {
 		return null;
 	}
-
-	return formattedLabel.endsWith( '?' ) ? formattedLabel : formattedLabel.replace( /:$/, '' ) + ':';
+	// Special case for the Terms consent field block which has a period at the end of the text.
+	return formattedLabel.endsWith( '?' )
+		? formattedLabel
+		: formattedLabel.replace( /[.:]$/, '' ) + ':';
 };
 
 const maybeTransformValue = value => {

projects/plugins/jetpack/changelog/fix-form-consent-label-colon-issue

@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Forms: strip period from Terms submission label on the post-submission page.