-
Notifications
You must be signed in to change notification settings - Fork 842
Closed
Closed
Copy link
Labels
AMP[Feature] MasterbarWordPress.com Toolbar and Dashboard customizationsWordPress.com Toolbar and Dashboard customizations[Pri] High[Type] BugWhen a feature is broken and / or not performing as intendedWhen a feature is broken and / or not performing as intended
Description
Steps to reproduce the issue
- Check out Masterbar: Revert recent changes #12454
- Activate the WordPress.com Toolbar feature on your site, under Jetpack > Settings > Writing
- Make sure you are logged in with your WordPress.com account.
- In the masterbar, click on your gravatar.
- Click sign out.
- You will be signed out of your site, but not from WordPress.com.
In fact, as soon as you log out the Masterbar module stops loading, and thus this is never triggered:
add_action( 'wp_logout', array( $this, 'maybe_logout_user_from_wpcom' ) );-- https://github.com/Automattic/jetpack/pull/12454/files#diff-d73a71fc4f0617de9989f4321bc4f39cR145
This appears to be caused by #10945 and #11088, which defered loading of the module altogether. Logging out of WordPress.com worked before those changes.
Metadata
Metadata
Assignees
Labels
AMP[Feature] MasterbarWordPress.com Toolbar and Dashboard customizationsWordPress.com Toolbar and Dashboard customizations[Pri] High[Type] BugWhen a feature is broken and / or not performing as intendedWhen a feature is broken and / or not performing as intended