-
Notifications
You must be signed in to change notification settings - Fork 839
Forms: Update DataViews to 10.0.1-next #45534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
BTW I'm not sure what happens if you don't update all the DataViews (MyJetpack, Scan, etc) at the same time; likely nothing as they're in different bundles but cc @Automattic/triforce in case. For final version bump we would want all packages I think, but since this is update between releases, just Forms seems fine. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
@lezama there's now a stable release, let's close this and update all the versions. I already checked DataViews from #23363 so the bot should open a PR soonish. |
Proposed changes:
@wordpress/dataviewsfrom 9.1.0 to 10.0.1-next.b8c8708f3.0 in Jetpack FormsOther information:
Breaking changes in DataViews 10.0.1-next:
isDestructiveprop removed from actions APIData<Item>typeThese breaking changes shouldn't affect Jetpack Forms as we're not using the affected APIs.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions: