Skip to content

Conversation

@lezama
Copy link
Contributor

@lezama lezama commented Oct 17, 2025

Proposed changes:

  • Updates @wordpress/dataviews from 9.1.0 to 10.0.1-next.b8c8708f3.0 in Jetpack Forms
  • This brings enhancements to the Forms responses DataViews interface including:
    • Better UX with always-visible select-all checkbox in table header
    • Improved search field design with icon in prefix position
    • Enhanced form validation support for date/datetime fields
    • Dynamic modal header support for better flexibility
    • Various bug fixes for grid view and search field normalization

Other information:

  • Have you written new tests for your changes, if applicable? (No new tests needed - dependency update only)
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Breaking changes in DataViews 10.0.1-next:

  • DataForm select control no longer injects empty values automatically
  • DataForm summary field moved from field level to layout level
  • isDestructive prop removed from actions API
  • Removed Data<Item> type

These breaking changes shouldn't affect Jetpack Forms as we're not using the affected APIs.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Verify the DataViews interface works correctly:
    • View displays with visible select-all checkbox
    • Search functionality works
    • Filtering and sorting work as expected
    • Grid view displays correctly
    • No console errors appear
  2. Test bulk actions with the select-all functionality

@lezama lezama requested a review from a team October 17, 2025 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/forms-dataviews-10-next branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-dataviews-10-next
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/forms-dataviews-10-next

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 17, 2025
@simison
Copy link
Member

simison commented Oct 17, 2025

BTW I'm not sure what happens if you don't update all the DataViews (MyJetpack, Scan, etc) at the same time; likely nothing as they're in different bundles but cc @Automattic/triforce in case.

For final version bump we would want all packages I think, but since this is update between releases, just Forms seems fine.

@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison
Copy link
Member

simison commented Oct 20, 2025

@lezama there's now a stable release, let's close this and update all the versions. I already checked DataViews from #23363 so the bot should open a PR soonish.

@simison simison closed this Oct 20, 2025
@simison simison deleted the update/forms-dataviews-10-next branch October 20, 2025 11:44
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 20, 2025
@simison
Copy link
Member

simison commented Oct 20, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants