refactor: replace hasOwnProperty with Object.hasOwn for safer property checks

Author: AbdelrahmanHafez

lib/helpers/projection/applyProjection.js

@@ -43,7 +43,7 @@ function applyExclusiveProjection(doc, projection, hasIncludedChildren, projecti
 
   for (const key of Object.keys(ret)) {
     const fullPath = prefix ? prefix + '.' + key : key;
-    if (projection.hasOwnProperty(fullPath) || projectionLimb.hasOwnProperty(key)) {
+    if (Object.hasOwn(projection, fullPath) || Object.hasOwn(projectionLimb, key)) {
       if (isPOJO(projection[fullPath]) || isPOJO(projectionLimb[key])) {
         ret[key] = applyExclusiveProjection(ret[key], projection, hasIncludedChildren, projectionLimb[key], fullPath);
       } else {

lib/helpers/update/decorateUpdateWithVersionKey.js

@@ -31,5 +31,5 @@ function hasKey(obj, key) {
   if (obj == null || typeof obj !== 'object') {
     return false;
   }
-  return Object.prototype.hasOwnProperty.call(obj, key);
+  return Object.hasOwn(obj, key);
 }

lib/types/array/index.js

@@ -79,13 +79,13 @@ function MongooseArray(values, path, doc, schematype) {
 
   const proxy = new Proxy(__array, {
     get: function(target, prop) {
-      if (internals.hasOwnProperty(prop)) {
+      if (Object.hasOwn(internals, prop)) {
         return internals[prop];
       }
-      if (mongooseArrayMethods.hasOwnProperty(prop)) {
+      if (Object.hasOwn(mongooseArrayMethods, prop)) {
         return mongooseArrayMethods[prop];
       }
-      if (schematype && schematype.virtuals && schematype.virtuals.hasOwnProperty(prop)) {
+      if (schematype && schematype.virtuals && Object.hasOwn(schematype.virtuals, prop)) {
         return schematype.virtuals[prop].applyGetters(undefined, target);
       }
       if (typeof prop === 'string' && numberRE.test(prop) && schematype?.embeddedSchemaType != null) {

lib/types/documentArray/index.js

@@ -73,16 +73,16 @@ function MongooseDocumentArray(values, path, doc, schematype) {
           prop === 'isMongooseDocumentArrayProxy') {
         return true;
       }
-      if (internals.hasOwnProperty(prop)) {
+      if (Object.hasOwn(internals, prop)) {
         return internals[prop];
       }
-      if (DocumentArrayMethods.hasOwnProperty(prop)) {
+      if (Object.hasOwn(DocumentArrayMethods, prop)) {
         return DocumentArrayMethods[prop];
       }
-      if (schematype && schematype.virtuals && schematype.virtuals.hasOwnProperty(prop)) {
+      if (schematype && schematype.virtuals && Object.hasOwn(schematype.virtuals, prop)) {
         return schematype.virtuals[prop].applyGetters(undefined, target);
       }
-      if (ArrayMethods.hasOwnProperty(prop)) {
+      if (Object.hasOwn(ArrayMethods, prop)) {
         return ArrayMethods[prop];
       }
 

lib/utils.js

@@ -711,18 +711,6 @@ exports.object.vals = function vals(o) {
   return ret;
 };
 
-const hop = Object.prototype.hasOwnProperty;
-
-/**
- * Safer helper for hasOwnProperty checks
- *
- * @param {Object} obj
- * @param {String} prop
- */
-
-exports.object.hasOwnProperty = function(obj, prop) {
-  return hop.call(obj, prop);
-};
 
 /**
  * Determine if `val` is null or undefined
@@ -773,8 +761,6 @@ exports.array.flatten = function flatten(arr, filter, ret) {
  * ignore
  */
 
-const _hasOwnProperty = Object.prototype.hasOwnProperty;
-
 exports.hasUserDefinedProperty = function(obj, key) {
   if (obj == null) {
     return false;
@@ -789,7 +775,7 @@ exports.hasUserDefinedProperty = function(obj, key) {
     return false;
   }
 
-  if (_hasOwnProperty.call(obj, key)) {
+  if (Object.hasOwn(obj, key)) {
     return true;
   }
   if (typeof obj === 'object' && key in obj) {