Merge pull request #16093 from mahmoodhamdi/fix/issue-16051-setters-on-setDefaultsOnInsert

fix(setDefaultsOnInsert): run setters on default values during upsert

Author: vkarpov15

lib/helpers/setDefaultsOnInsert.js

@@ -84,7 +84,7 @@ module.exports = function(filter, schema, castedDoc, options, queryMongooseOptio
     if (schemaType.path === '_id' && schemaType.options.auto) {
       return;
     }
-    const def = schemaType.getDefault(null, true, { context });
+    const def = schemaType.getDefault(null, false, { context });
     if (typeof def === 'undefined') {
       return;
     }

test/helpers/setDefaultsOnInsert.test.js

@@ -107,6 +107,25 @@ describe('setDefaultsOnInsert', function() {
     assert.equal(update.$setOnInsert['referralConversion'], 'bar');
   });
 
+  it('runs setters on default values (gh-16051)', function() {
+    const schema = new Schema({
+      name: String,
+      slug: {
+        type: String,
+        default: 'Hello World!',
+        set: function(v) {
+          return v.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/(^-|-$)/g, '');
+        }
+      }
+    });
+
+    const opts = { upsert: true, setDefaultsOnInsert: true };
+    let update = { $set: { name: 'test' } };
+    update = setDefaultsOnInsert({}, schema, update, opts);
+
+    assert.equal(update.$setOnInsert['slug'], 'hello-world');
+  });
+
   it('skips default if parent is $set (gh-12279)', function() {
     const SubscriptionsConfigSchema = Schema({
       hasPaidSubscription: { type: Boolean, required: true },

test/model.updateOne.test.js

@@ -624,18 +624,14 @@ describe('model: updateOne:', function() {
 
     });
 
-    it('setDefaultsOnInsert does not run setters on default values (gh-16025)', async function() {
-      const setterContexts = [];
+    it('setDefaultsOnInsert runs setters on default values (gh-16051)', async function() {
       const schema = new Schema({
         name: String,
         slug: {
           type: String,
-          default: function() {
-            return this.get('name');
-          },
+          default: 'Hello World!',
           set: function(v) {
-            setterContexts.push(this);
-            return v;
+            return v.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/(^-|-$)/g, '');
           }
         }
       });
@@ -647,10 +643,8 @@ describe('model: updateOne:', function() {
         { upsert: true, setDefaultsOnInsert: true }
       );
 
-      assert.equal(setterContexts.length, 0);
-
       const doc = await Test.findOne({ name: 'foo' });
-      assert.equal(doc.slug, 'foo');
+      assert.equal(doc.slug, 'hello-world');
     });
 
     it('avoids nested paths if setting parent path (gh-4911)', function(done) {