refactor: standardize ActionScheduler group names to 'newspack'

Author: miguelpeixe

includes/data-events/class-data-events.php

@@ -81,11 +81,6 @@ final class Data_Events {
 	 */
 	private static $current_event = null;
 
-	/**
-	 * ActionScheduler group for dispatch actions.
-	 */
-	const DISPATCH_AS_GROUP = 'newspack-data-events-dispatch';
-
 	/**
 	 * ActionScheduler hook for handling dispatched events.
 	 */
@@ -96,11 +91,6 @@ final class Data_Events {
 	 */
 	const HANDLER_RETRY_HOOK = 'newspack_data_events_retry_handler';
 
-	/**
-	 * ActionScheduler group for handler retry actions.
-	 */
-	const HANDLER_RETRY_GROUP = 'newspack-data-events-handler-retry';
-
 	/**
 	 * Maximum number of retries for a failed handler.
 	 */
@@ -609,7 +599,7 @@ private static function dispatch_via_action_scheduler() {
 		\as_enqueue_async_action(
 			self::DISPATCH_AS_HOOK,
 			[ self::$queued_dispatches ],
-			self::DISPATCH_AS_GROUP
+			'newspack'
 		);
 
 		self::log( sprintf( 'Scheduled %d dispatch(es) via Action Scheduler.', count( self::$queued_dispatches ) ) );
@@ -725,7 +715,7 @@ private static function schedule_handler_retry( $handler, $action_name, $timesta
 			time() + $backoff_seconds,
 			self::HANDLER_RETRY_HOOK,
 			[ $retry_data ],
-			self::HANDLER_RETRY_GROUP
+			'newspack'
 		);
 
 		self::log(

includes/data-events/class-webhooks.php

@@ -732,7 +732,7 @@ private static function schedule_request( $request_id, $delay = 1 ) {
 				$time,
 				'newspack_webhooks_as_process_request',
 				[ $request_id ],
-				'newspack-data-events',
+				'newspack',
 				false,
 				self::get_request_priority( $request_id )
 			);

includes/plugins/woocommerce-subscriptions/class-on-hold-duration.php

@@ -18,11 +18,6 @@ class On_Hold_Duration {
 	 */
 	const AS_HOOK = 'newspack_expire_manual_subscription';
 
-	/**
-	 * The group name for the manual subscription expiration scheduled action.
-	 */
-	const AS_GROUP = 'newspack_expire_manual_subscription';
-
 	/**
 	 * Initialize hooks and filters.
 	 */
@@ -141,8 +136,8 @@ public static function maybe_schedule_expiration( $subscription ) {
 	 * @param int $timestamp       Timestamp.
 	 */
 	public static function schedule_expiration( $subscription_id, $timestamp ) {
-		if ( ! as_has_scheduled_action( self::AS_HOOK, [ $subscription_id ], self::AS_GROUP ) ) {
-			as_schedule_single_action( $timestamp, self::AS_HOOK, [ $subscription_id ], self::AS_GROUP );
+		if ( ! as_has_scheduled_action( self::AS_HOOK, [ $subscription_id ], 'newspack' ) ) {
+			as_schedule_single_action( $timestamp, self::AS_HOOK, [ $subscription_id ], 'newspack' );
 		}
 	}
 
@@ -152,8 +147,8 @@ public static function schedule_expiration( $subscription_id, $timestamp ) {
 	 * @param \WC_Subscription $subscription The Subscription.
 	 */
 	public static function maybe_unschedule_expiration( $subscription ) {
-		if ( false !== as_has_scheduled_action( self::AS_HOOK, [ $subscription->get_id() ], self::AS_GROUP ) ) {
-			as_unschedule_action( self::AS_HOOK, [ $subscription->get_id() ], self::AS_GROUP );
+		if ( false !== as_has_scheduled_action( self::AS_HOOK, [ $subscription->get_id() ], 'newspack' ) ) {
+			as_unschedule_action( self::AS_HOOK, [ $subscription->get_id() ], 'newspack' );
 		}
 	}
 

includes/reader-activation/sync/class-contact-sync.php

@@ -181,7 +181,7 @@ private static function schedule_integration_retry( $integration_id, $contact, $
 			time() + $backoff_seconds,
 			self::RETRY_HOOK,
 			[ $retry_data ],
-			self::RETRY_GROUP
+			'newspack'
 		);
 
 		static::log(