refactor: define shouldPublishOnNPM when needed

dkoo · dkoo · commit 1b5b2a1ce3a2 · 2025-10-15T17:07:11.000-06:00
diff --git a/scripts/release.js b/scripts/release.js
@@ -12,8 +12,6 @@ const filesList = files.split( ',' );
 
 utils.log( `Releasing ${ process.env.CIRCLE_PROJECT_REPONAME }…` );
 
-let shouldPublishOnNPM = Boolean( process.env.NPM_TOKEN );
-
 const getConfig = ({ gitBranchName }) => {
 	const branchType = gitBranchName.split("/")[0];
 	const githubConfig = {
@@ -32,7 +30,7 @@ const getConfig = ({ gitBranchName }) => {
 	}
 
 	// Only publish alpha and release branches to NPM.
-	shouldPublishOnNPM = shouldPublishOnNPM && ["alpha", "release"].includes(branchType);
+	const shouldPublishOnNPM = Boolean( process.env.NPM_TOKEN ) && ["alpha", "release"].includes(branchType);
 	if ( shouldPublishOnNPM ) {
 		utils.log( `Will publish to npm.` );
 	}

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,6 @@ const filesList = files.split( ',' );`
`12`	`12`
`13`	`13`	utils.log( `Releasing ${ process.env.CIRCLE_PROJECT_REPONAME }…` );
`14`	`14`
`15`		`-let shouldPublishOnNPM = Boolean( process.env.NPM_TOKEN );`
`16`		`-`
`17`	`15`	`const getConfig = ({ gitBranchName }) => {`
`18`	`16`	`const branchType = gitBranchName.split("/")[0];`
`19`	`17`	`const githubConfig = {`
`@@ -32,7 +30,7 @@ const getConfig = ({ gitBranchName }) => {`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`// Only publish alpha and release branches to NPM.`
`35`		`- shouldPublishOnNPM = shouldPublishOnNPM && ["alpha", "release"].includes(branchType);`
	`33`	`+ const shouldPublishOnNPM = Boolean( process.env.NPM_TOKEN ) && ["alpha", "release"].includes(branchType);`
`36`	`34`	`if ( shouldPublishOnNPM ) {`
`37`	`35`	utils.log( `Will publish to npm.` );
`38`	`36`	`}`