The efficiency of fillText has decreased in version 3.2.0

[yinhui1129754]

In version 2.11.2, filling text with fillText only took 0.1-0.5ms, but now that it has been updated to version 3.2.0, filling text with fillText takes more than 3ms.

[chearon]

Could you please fill out the issue template? I need to know at least what OS and ideally a minimal reproduction.

I wrote this benchmark:

const { bench, run } = require('mitata')
const { createCanvas } = require('./index')

const canvas = createCanvas(200, 200)
const ctx = canvas.getContext('2d')

bench('ctx.fillText', () => {
  ctx.fillText('Hello World', 10, 50)
})

run()

And I got 19.2µs for 2.11.2, 19.57µs for 3.2.1, which is about right considering we switched to NAPI.

[yinhui1129754]

Could you please fill out the issue template? I need to know at least what OS and ideally a minimal reproduction.

I wrote this benchmark:

const { bench, run } = require('mitata')
const { createCanvas } = require('./index')

const canvas = createCanvas(200, 200)
const ctx = canvas.getContext('2d')

bench('ctx.fillText', () => {
ctx.fillText('Hello World', 10, 50)
})

run()
And I got 19.2µs for 2.11.2, 19.57µs for 3.2.1, which is about right considering we switched to NAPI.

System environment: Windows 10
Node version: 18.20.3
The test code for versions 3.2.0 and 2.11.2 is identical:

var pdf = Canvas.createCanvas(1920, 1080, "pdf");
let ctx = pdf.getContext("2d");
ctx.textDrawingMode = "glyph";
ctx.font = "30pt simsun";
ctx.fillRect(0, 0, 100, 100);
let str = "Hello world";

for (var i = 0; i < str.length; i++) {
  console.time("time1");
  ctx.fillText(str[i], 100 + i * 50, 100 + i * 5);
  console.timeEnd("time1");
}

The output result of version 3.2.0 is as follows:

The output result of version 2.11.2 is as follows:

In version 3.2.1, I noticed that the efficiency has improved again.
The output result of version 3.2.1 is as follows:

[yinhui1129754]

Could you please fill out the issue template? I need to know at least what OS and ideally a minimal reproduction.

I wrote this benchmark:

const { bench, run } = require('mitata')
const { createCanvas } = require('./index')

const canvas = createCanvas(200, 200)
const ctx = canvas.getContext('2d')

bench('ctx.fillText', () => {
ctx.fillText('Hello World', 10, 50)
})

run()
And I got 19.2µs for 2.11.2, 19.57µs for 3.2.1, which is about right considering we switched to NAPI.

3.2.1 has been fixed, thank you