Fix: Always provide an updated user for crash logging purposes

PR Comment: #1731
#discussion_r2231064987

Author: ParaskP7

Simplenote/src/main/java/com/automattic/simplenote/utils/crashlogging/SimplenoteCrashLoggingDataProvider.kt

@@ -1,5 +1,6 @@
 package com.automattic.simplenote.utils.crashlogging
 
+import android.util.Log
 import com.automattic.android.tracks.crashlogging.CrashLoggingDataProvider
 import com.automattic.android.tracks.crashlogging.CrashLoggingUser
 import com.automattic.android.tracks.crashlogging.EventLevel
@@ -11,13 +12,14 @@ import com.automattic.simplenote.Simplenote
 import com.automattic.simplenote.utils.locale.LocaleProvider
 import com.simperium.client.User
 import kotlinx.coroutines.flow.Flow
-import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.flow.catch
 import kotlinx.coroutines.flow.emptyFlow
+import kotlinx.coroutines.flow.flow
 import java.util.Locale
 import javax.inject.Inject
 
 class SimplenoteCrashLoggingDataProvider @Inject constructor(
-    app: Simplenote,
+    private val app: Simplenote,
     private val localeProvider: LocaleProvider,
 ) : CrashLoggingDataProvider {
 
@@ -34,7 +36,8 @@ class SimplenoteCrashLoggingDataProvider @Inject constructor(
         ReleaseName.SetByTracksLibrary
     }
 
-    override val user: Flow<CrashLoggingUser?> = MutableStateFlow(app.simperium?.user?.toCrashLoggingUser())
+    override val user: Flow<CrashLoggingUser?>
+        get() = provideUser()
 
     override val applicationContextProvider: Flow<Map<String, String>> = emptyFlow()
 
@@ -60,6 +63,14 @@ class SimplenoteCrashLoggingDataProvider @Inject constructor(
         return false
     }
 
+    private fun provideUser(): Flow<CrashLoggingUser?> =
+        flow {
+            emit(app.simperium?.user?.toCrashLoggingUser())
+        }.catch { e ->
+            Log.e(TAG, "Exception getting the user", e)
+            emit(null)
+        }
+
     private fun User.toCrashLoggingUser(): CrashLoggingUser? {
         if (userId.isNullOrEmpty()) return null
 
@@ -71,6 +82,7 @@ class SimplenoteCrashLoggingDataProvider @Inject constructor(
     }
 
     companion object {
-        const val DEBUG_RELEASE_NAME = "debug"
+        private const val DEBUG_RELEASE_NAME = "debug"
+        private val TAG: String = SimplenoteCrashLoggingDataProvider::class.java.getSimpleName()
     }
 }