Update: use simplenote:user_id instead of wpcom:user_id for Tracks (#3291)

Author: codebykat

RELEASE-NOTES.md

@@ -6,6 +6,7 @@
 
 - Updated styles, sass, style linting [#3294](https://github.com/Automattic/simplenote-electron/pull/3294)
 - Upgraded dependencies [#3292](https://github.com/Automattic/simplenote-electron/pull/3292)
+- Updated the ID type used for analytics to avoid sending invalid WPCOM IDs [#3291](https://github.com/Automattic/simplenote-electron/pull/3291)
 
 ## [v2.23.1]
 

lib/analytics/tracks.ts

@@ -106,16 +106,6 @@ function buildTracks() {
     setCookie(key, value, ttl);
   };
 
-  const loadWpcomIdentity = function () {
-    const wpcomCookie =
-      getCookie('wordpress') ||
-      getCookie('wordpress_sec') ||
-      getCookie('wordpress_loggedin');
-    if (wpcomCookie) {
-      return get(userNameCookie);
-    }
-  };
-
   const newAnonId = function () {
     const randomBytesLength = 18; // 18 * 4/3 = 24
     let randomBytes: number[] | Uint8Array = [];
@@ -133,23 +123,6 @@ function buildTracks() {
     return btoa(String.fromCharCode.apply(String, randomBytes as number[]));
   };
 
-  const loadIdentity = function () {
-    if (userId) {
-      return;
-    }
-    userId = loadWpcomIdentity();
-    if (userId) {
-      userIdType = 'wpcom:user_id';
-    } else {
-      userIdType = 'anon';
-      userId = get(userAnonCookie);
-      if (!userId) {
-        userId = newAnonId();
-        set(userAnonCookie, userId);
-      }
-    }
-  };
-
   const getQueries = function () {
     const queries = get(queriesCookie);
     return queries ? queries.split(' ') : [];
@@ -238,7 +211,6 @@ function buildTracks() {
   };
 
   const send = function (query: Query) {
-    loadIdentity();
     retryQueries();
     query._ui = userId;
     query._ut = userIdType;
@@ -317,7 +289,7 @@ function buildTracks() {
     }
 
     userId = newUserId;
-    userIdType = 'wpcom:user_id';
+    userIdType = 'simplenote:user_id';
     set(userNameCookie, userId);
     const anonId = get(userAnonCookie);
     if (anonId) {
@@ -334,7 +306,6 @@ function buildTracks() {
     userLogin = null;
     set(userNameCookie, '', -1);
     set(userAnonCookie, '', -1);
-    loadIdentity();
   };
 
   const setProperties = function (properties: Query) {