On Russian keyboards, "Б" character adds a tag

[codebykat]

Expected

We should split on commas regardless of keyboard layout

Observed

On Russian keyboards, the "Б" character is apparently the same keycode as the comma on English keyboards so typing it causes a tag to be added.

It's possible this also implies that comma doesn't work to add a tag for Russian keyboards (since it would be a different keycode). I haven't tested that scenario.

User reported in 2896068-zen and reproduced it in Windows 10 and on web.

[codebykat]

Research for later:

aehlke/tag-it#22
aehlke/tag-it#140
aehlke/tag-it#251 (comment)

And by the way, on Russan layout, COMMA is a keycode 191 with SHIFT pressed. So pressing this COMMA does not insert new tag.

when i type "ม" in thai language this "ม" is same button "," (comma).
i change condition split tag (c.which===b.ui.keyCode.COMMA&&!1===c.shiftKey) to (event.key === ",").
i can type "ม"

[dmsnell]

Nice. We should be able to fix this. In the keybindings audit we missed this one - it relies on the old constants for keypress, which is silly. We'll update to use the , - thanks @codebykat for the link to that tag-it PR

[rezzap]

User has provided the following information and recording of the issue to explain the issue further.

Comma in english layout adds tag instantly.
Comma in russian layout separated tag to several after Enter pressing (see attached video

[msilbers]

reported in 3294593-zen

[dmsnell]

@rezzap the video demonstrates another aspect of tagging - tags are separated by a space. this has always been how tags work as far as I can remember. originally it made it easier to add multiple tags from a mobile device.

[reginabally]

Another report in 3333717-zen.

[codebykat]

This should have been fixed by #2334 but I just tested and it was not, so apparently I missed one.

[reginabally]

Reported in 3474956-zen with the small letter b in Russian - "б".

[eduardozulian]

Also reported in 3669598-zen with б