Skip to content

Commit 1db402b

Browse files
authored
Remove Windows binary size tracking from metrics job (#2811)
The Performance Metrics CI job runs exclusively on Mac agents and never builds a Windows binary, so the appSizeWin metric and its associated code path were dead code.
1 parent 55ea9a7 commit 1db402b

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

tools/metrics/metric-config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ const timeFormatter = ( value: number ) => `${ value } ms`;
1111

1212
export const METRIC_CONFIG: Record< string, MetricConfig > = {
1313
appSizeMac: { label: 'App Size (Mac)', format: sizeFormatter, threshold: BYTES_PER_MB },
14-
appSizeWin: { label: 'App Size (Win)', format: sizeFormatter, threshold: BYTES_PER_MB },
1514
};
1615

1716
const DEFAULT_METRIC_CONFIG: MetricConfig = { label: '', format: timeFormatter, threshold: 50 };

tools/metrics/tests/app-size.test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,11 @@ test.describe( 'App Size Metrics', () => {
1010
const results: Record< string, number > = {};
1111

1212
const macDir = path.join( outDir, 'Studio-darwin-arm64', 'Studio.app' );
13-
const winDir = path.join( outDir, 'Studio-win32-x64' );
1413

1514
if ( fs.existsSync( macDir ) ) {
1615
results.appSizeMac = getDirSize( macDir );
17-
} else if ( fs.existsSync( winDir ) ) {
18-
results.appSizeWin = getDirSize( winDir );
1916
} else {
20-
throw new Error(
21-
`Could not find packaged app directory under ${ outDir }. Run 'npm run package' first.`
22-
);
17+
throw new Error( `Could not find packaged app at ${ macDir }. Run 'npm run package' first.` );
2318
}
2419

2520
await testInfo.attach( 'results', {

0 commit comments

Comments
 (0)