blank endpoint_url in PushClient::test_connection()

[vladimirdulov]

Hi,

We are using Syndication 2.1 and faced with the error "Something went wrong when connecting to the site. Site disabled." after submitting the plugin settings, e.g. OAuth token. After some research we found out that it failed in Client_Manager ::test_connection() whilst it's testing the connection.

We've got it working properly by applying the following patch:

index a5cc30d..2959f04 100644
--- a/includes/clients/rest-push-new/class-push-client.php
+++ b/includes/clients/rest-push-new/class-push-client.php
@@ -452,6 +452,7 @@ class Push_Client extends Pusher {
         * @return bool
         */
        public function test_connection( $site_id ) {
+               $this->init( $site_id );
                $response = wp_remote_get(
                        $this->endpoint_url . '/wp-json/wp/v2/posts',
                        array(

We propose to include it into upstream so it hasn't been lost after upgrade.

Thank you,
Vladimir

[GaryJones]

Moved to 3.0.0 milestone. The affected code (includes/clients/rest-push-new/class-push-client.php) only exists in the origin/2.1 branch which was never merged to develop. This fix will be applied when the 2.1 branch code is rebased and modernised for the 3.0.0 release.