Merge pull request #2470 from Automattic/fix/url-parse-deprecation

refactor: remove deprecated `url.parse()` in favor of WHATWG URL API

Author: sjinks

__tests__/lib/analytics/clients/tracks.js

@@ -1,38 +1,16 @@
 import nock from 'nock';
-import url from 'url';
 
 import Tracks from '../../../../src/lib/analytics/clients/tracks';
 import * as apiConfig from '../../../../src/lib/cli/apiConfig';
 
 describe( 'lib/analytics/tracks', () => {
-	const {
-		protocol: endpointProtocol,
-		host: endpointHost,
-		path: endpointPath,
-	} = url.parse( Tracks.ENDPOINT );
+	const url = new URL( Tracks.ENDPOINT );
 
-	const buildNock = () => {
-		return nock( `${ endpointProtocol }//${ endpointHost }` ).post( endpointPath );
-	};
+	const buildNock = () => nock( url.origin ).post( url.pathname );
 
 	afterEach( nock.cleanAll );
 
 	describe( '.send()', () => {
-		/**
-		 * Allow overriding of process variables per test
-		 * Adapted from https://stackoverflow.com/a/48042799
-		 */
-		const OLD_ENV = process.env;
-
-		beforeEach( () => {
-			jest.resetModules();
-			process.env = { ...OLD_ENV };
-		} );
-
-		afterEach( () => {
-			process.env = OLD_ENV;
-		} );
-
 		it( 'should correctly construct remote request', () => {
 			const tracksClient = new Tracks( 123, 'vip', '', {
 				userAgent: 'vip-cli',

__tests__/lib/validations/is-multisite-domain-mapped.js

@@ -3,7 +3,6 @@
  */
 
 import nock from 'nock';
-import url from 'url';
 
 import { API_URL } from '../../../src/lib/api';
 import {
@@ -80,10 +79,10 @@ describe( 'is-multisite-domain-mapped', () => {
 
 	describe( 'isMultisitePrimaryDomainMapped', () => {
 		beforeEach( () => {
-			const { protocol, host, path } = url.parse( API_URL );
+			const url = new URL( API_URL );
 
-			nock( `${ protocol }//${ host }` )
-				.post( path )
+			nock( url.origin )
+				.post( url.pathname )
 				.reply( 200, {
 					data: {
 						app: {

src/bin/vip-import-validate-files.js

@@ -4,7 +4,6 @@
  * External dependencies
  */
 import chalk from 'chalk';
-import url from 'url';
 
 /**
  * Internal dependencies
@@ -29,9 +28,7 @@ export async function vipImportValidateFilesCmd( arg = [] ) {
 	 *
 	 * Manipulating the file path/name to extract the folder name
 	 */
-	const folder = arg.join(); // File comes in as an array as part of the args- turn it into a string
-	arg = url.parse( folder ); // Then parse the file to its URL parts
-	const filePath = arg.path; // Extract the path of the file
+	const filePath = arg.join(); // File comes in as an array as part of the args- turn it into a string
 
 	if ( ! ( await isDirectory( filePath ) ) ) {
 		console.error(