fix: drop superfluous as unknown casts

Author: sjinks

__tests__/commands/wp-ssh.ts

@@ -105,7 +105,7 @@ describe( 'WPCommand', () => {
 
 				// Simulate the SSH connection closing right after the command is executed
 				dummyStream.emit( 'close' );
-			} ) as unknown as Client[ 'exec' ] );
+			} ) as Client[ 'exec' ] );
 
 			await cmd.run( 'plugin list' );
 
@@ -129,7 +129,7 @@ describe( 'WPCommand', () => {
 				callback: ( err: Error, stream: Stream ) => void
 			) => {
 				callback( new Error( 'ops!' ), dummyStream );
-			} ) as unknown as Client[ 'exec' ] );
+			} ) as Client[ 'exec' ] );
 
 			const result = cmd.run( 'plugin list' );
 
@@ -150,7 +150,7 @@ describe( 'WPCommand', () => {
 				// Simulate the SSH connection closing right after the command is executed
 				dummyStream.emit( 'exit', 23 );
 				dummyStream.emit( 'close' );
-			} ) as unknown as Client[ 'exec' ] );
+			} ) as Client[ 'exec' ] );
 
 			const result = cmd.run( 'plugin list' );
 

src/commands/export-sql.ts

@@ -387,9 +387,7 @@ export class ExportSQLCommand {
 			return await this.confirmEnoughStorageHook( job );
 		}
 
-		const storageAvailability = BackupStorageAvailability.createFromDbCopyJob(
-			job as unknown as Job
-		);
+		const storageAvailability = BackupStorageAvailability.createFromDbCopyJob( job );
 		return await storageAvailability.validateAndPromptDiskSpaceWarningForBackupImport();
 	}
 

src/lib/dev-environment/dev-environment-core.ts

@@ -951,7 +951,7 @@ export function fetchVersionList(): Promise< WordPressTag[] > {
 	// TODO: remove this cast once the typings are fixed
 	const proxyAgent = createProxyAgent( url ) as unknown as Agent;
 	return fetch( url, { agent: proxyAgent ?? undefined } ).then(
-		res => res.json() as unknown as WordPressTag[]
+		res => res.json() as Promise< WordPressTag[] >
 	);
 }
 

src/lib/media-import/config.ts

@@ -24,5 +24,5 @@ export async function getMediaImportConfig(): Promise< MediaImportConfig | null
 		fetchPolicy: 'network-only',
 	} );
 
-	return response?.data?.mediaImportConfig as unknown as MediaImportConfig | null;
+	return response?.data?.mediaImportConfig ?? null;
 }

src/lib/media-import/status.ts

@@ -363,9 +363,7 @@ Downloading errors details from ${ fileErrorsUrl }
 		progressTracker.print();
 
 		if ( results.failureDetails?.fileErrorsUrl ) {
-			await promptFailureDetailsDownload(
-				results.failureDetails.fileErrorsUrl as unknown as string
-			);
+			await promptFailureDetailsDownload( results.failureDetails.fileErrorsUrl );
 		} else if ( 'ABORTED' !== overallStatus ) {
 			// print report link expired if required
 			// do not print this message if the import was aborted