Fix customer not found errors after site migration (#5383)

* Fix customer not found errors after site migration

After a site has been migrated to a different WCPay account pre-existing
account will be associated with Stripe customer objects that don't
exist. This will result in a "No such customer" error in UPE checkouts
and a "We're not able to process this request" error in classic
checkouts.

To fix the issue we make the customer update function synchronous
instead of asynchronous. This rolls back a significant performance
update, but WCPay stores shouldn't hit this path most of the time
anyway, so it shouldn't matter for most stores.

Author: reykjalin

changelog/fix-customer-not-found-error-after-account-migration

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Prevent 'No such customer' errors after store is migrated to a new WCPay account.

includes/class-wc-payment-gateway-wcpay.php

@@ -70,8 +70,7 @@ class WC_Payment_Gateway_WCPay extends WC_Payment_Gateway_CC {
 		Payment_Intent_Status::PROCESSING,
 	];
 
-	const UPDATE_SAVED_PAYMENT_METHOD     = 'wcpay_update_saved_payment_method';
-	const UPDATE_CUSTOMER_WITH_ORDER_DATA = 'wcpay_update_customer_with_order_data';
+	const UPDATE_SAVED_PAYMENT_METHOD = 'wcpay_update_saved_payment_method';
 
 	/**
 	 * Set a large limit argument for retrieving user tokens.
@@ -410,7 +409,6 @@ public function __construct(
 		add_action( 'set_logged_in_cookie', [ $this, 'set_cookie_on_current_request' ] );
 
 		add_action( self::UPDATE_SAVED_PAYMENT_METHOD, [ $this, 'update_saved_payment_method' ], 10, 3 );
-		add_action( self::UPDATE_CUSTOMER_WITH_ORDER_DATA, [ $this, 'update_customer_with_order_data' ], 10, 4 );
 
 		// Update the email field position.
 		add_filter( 'woocommerce_billing_fields', [ $this, 'checkout_update_email_field_priority' ], 50 );
@@ -830,12 +828,12 @@ protected function prepare_payment_information( $order ) {
 	/**
 	 * Update the customer details with the incoming order data, in a CRON job.
 	 *
-	 * @param int    $order_id     WC order id.
-	 * @param string $customer_id  The customer id to update details for.
-	 * @param bool   $is_test_mode Whether to run the CRON job in test mode.
-	 * @param bool   $is_woopay    Whether CRON job was queued from WooPay.
+	 * @param \WC_Order $order        WC order id.
+	 * @param string    $customer_id  The customer id to update details for.
+	 * @param bool      $is_test_mode Whether to run the CRON job in test mode.
+	 * @param bool      $is_woopay    Whether CRON job was queued from WooPay.
 	 */
-	public function update_customer_with_order_data( $order_id, $customer_id, $is_test_mode = false, $is_woopay = false ) {
+	public function update_customer_with_order_data( $order, $customer_id, $is_test_mode = false, $is_woopay = false ) {
 		// Since this CRON job may have been created in test_mode, when the CRON job runs, it
 		// may lose the test_mode context. So, instead, we pass that context when creating
 		// the CRON job and apply the context here.
@@ -844,8 +842,7 @@ public function update_customer_with_order_data( $order_id, $customer_id, $is_te
 		};
 		add_filter( 'wcpay_test_mode', $apply_test_mode_context );
 
-		$order = wc_get_order( $order_id );
-		$user  = $order->get_user();
+		$user = $order->get_user();
 		if ( false === $user ) {
 			$user = wp_get_current_user();
 		}
@@ -890,16 +887,7 @@ protected function manage_customer_details_for_order( $order, $options = [] ) {
 			$customer_id = $this->customer_service->create_customer_for_user( $user, $customer_data );
 		} else {
 			// Update the customer with order data async.
-			$this->action_scheduler_service->schedule_job(
-				time(),
-				self::UPDATE_CUSTOMER_WITH_ORDER_DATA,
-				[
-					'order_id'     => $order->get_id(),
-					'customer_id'  => $customer_id,
-					'is_test_mode' => $this->is_in_test_mode(),
-					'is_woopay'    => $options['is_woopay'] ?? false,
-				]
-			);
+			$this->update_customer_with_order_data( $order, $customer_id, $this->is_in_test_mode(), $options['is_woopay'] ?? false );
 		}
 
 		return [ $user, $customer_id ];

tests/unit/test-class-wc-payment-gateway-wcpay-process-payment.php

@@ -18,6 +18,8 @@
  * WC_Payment_Gateway_WCPay unit tests.
  */
 class WC_Payment_Gateway_WCPay_Process_Payment_Test extends WCPAY_UnitTestCase {
+	const CUSTOMER_ID = 'cus_mock';
+
 	/**
 	 * System under test.
 	 *
@@ -1080,20 +1082,10 @@ public function test_updates_customer_with_order_data() {
 			->method( 'get_customer_id_by_user_id' )
 			->willReturn( $customer_id );
 
-		// Assert: UPDATE_CUSTOMER_WITH_ORDER_DATA job scheduled correctly.
-		$this->mock_action_scheduler_service
+		$this->mock_customer_service
 			->expects( $this->once() )
-			->method( 'schedule_job' )
-			->with(
-				$this->anything(),
-				WC_Payment_Gateway_WCPay::UPDATE_CUSTOMER_WITH_ORDER_DATA,
-				[
-					'order_id'     => $mock_order->get_id(),
-					'customer_id'  => $customer_id,
-					'is_test_mode' => false,
-					'is_woopay'    => false,
-				]
-			);
+			->method( 'update_customer_for_user' )
+			->willReturn( self::CUSTOMER_ID );
 
 		// Arrange: Create a mock cart.
 		$mock_cart = $this->createMock( 'WC_Cart' );

tests/unit/test-class-wc-payment-gateway-wcpay-subscriptions-process-payment.php

@@ -160,6 +160,11 @@ public function set_up() {
 			->with( get_current_user_id() )
 			->willReturn( self::CUSTOMER_ID );
 
+		$this->mock_customer_service
+			->expects( $this->once() )
+			->method( 'update_customer_for_user' )
+			->willReturn( self::CUSTOMER_ID );
+
 		$this->token = WC_Helper_Token::create_token( self::PAYMENT_METHOD_ID, self::USER_ID );
 
 		$_POST = [

tests/unit/test-class-wc-payment-gateway-wcpay-subscriptions.php

@@ -228,6 +228,11 @@ public function test_scheduled_subscription_payment() {
 			->with( self::USER_ID )
 			->willReturn( self::CUSTOMER_ID );
 
+		$this->mock_customer_service
+			->expects( $this->once() )
+			->method( 'update_customer_for_user' )
+			->willReturn( self::CUSTOMER_ID );
+
 		$this->mock_api_client
 			->expects( $this->once() )
 			->method( 'create_and_confirm_intention' )